[PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[Haiyue Wang]

The commit b38747291d50 ("queue: break reg wait setup") just left this
API definition with always "-EINVAL" result for building test.

And new API 'io_uring_submit_and_wait_reg' has been implemented.

Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
 src/include/liburing.h | 2 --
 src/liburing-ffi.map   | 1 -
 src/liburing.map       | 1 -
 src/register.c         | 6 ------
 4 files changed, 10 deletions(-)

diff --git a/src/include/liburing.h b/src/include/liburing.h
index a953a6f..8dfbf31 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -210,8 +210,6 @@ int io_uring_submit_and_wait_reg(struct io_uring *ring,
 				 struct io_uring_cqe **cqe_ptr, unsigned wait_nr,
 				 int reg_index);
 
-int io_uring_register_wait_reg(struct io_uring *ring,
-			       struct io_uring_reg_wait *reg, int nr);
 int io_uring_resize_rings(struct io_uring *ring, struct io_uring_params *p);
 int io_uring_clone_buffers_offset(struct io_uring *dst, struct io_uring *src,
 				  unsigned int dst_off, unsigned int src_off,
diff --git a/src/liburing-ffi.map b/src/liburing-ffi.map
index 7f6d4af..662840d 100644
--- a/src/liburing-ffi.map
+++ b/src/liburing-ffi.map
@@ -219,7 +219,6 @@ LIBURING_2.8 {
 LIBURING_2.9 {
 	global:
 		io_uring_resize_rings;
-		io_uring_register_wait_reg;
 		io_uring_submit_and_wait_reg;
 		io_uring_clone_buffers_offset;
 		io_uring_register_region;
diff --git a/src/liburing.map b/src/liburing.map
index c946115..84114d2 100644
--- a/src/liburing.map
+++ b/src/liburing.map
@@ -106,7 +106,6 @@ LIBURING_2.8 {
 
 LIBURING_2.9 {
 		io_uring_resize_rings;
-		io_uring_register_wait_reg;
 		io_uring_submit_and_wait_reg;
 		io_uring_clone_buffers_offset;
 		io_uring_register_region;
diff --git a/src/register.c b/src/register.c
index 51667d8..68944ed 100644
--- a/src/register.c
+++ b/src/register.c
@@ -471,12 +471,6 @@ out:
 	return ret;
 }
 
-int io_uring_register_wait_reg(struct io_uring *ring,
-			       struct io_uring_reg_wait *reg, int nr)
-{
-	return -EINVAL;
-}
-
 int io_uring_register_region(struct io_uring *ring,
 			     struct io_uring_mem_region_reg *reg)
 {
-- 
2.49.0

Re: [PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[Jens Axboe]

On 5/17/25 8:07 AM, Haiyue Wang wrote:
> The commit b38747291d50 ("queue: break reg wait setup") just left this
> API definition with always "-EINVAL" result for building test.
> 
> And new API 'io_uring_submit_and_wait_reg' has been implemented.

You can't just remove symbols from a previously released
version of the library...

-- 
Jens Axboe

Re: [PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[Haiyue Wang]

On 2025/5/17 22:20, Jens Axboe wrote:
> On 5/17/25 8:07 AM, Haiyue Wang wrote:
>> The commit b38747291d50 ("queue: break reg wait setup") just left this
>> API definition with always "-EINVAL" result for building test.
>>
>> And new API 'io_uring_submit_and_wait_reg' has been implemented.
> 
> You can't just remove symbols from a previously released
> version of the library...

Cna only remove during the development cycle ?

> 

Re: [PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[Jens Axboe]

On 5/17/25 8:31 AM, Haiyue Wang wrote:
> 
> 
> On 2025/5/17 22:20, Jens Axboe wrote:
>> On 5/17/25 8:07 AM, Haiyue Wang wrote:
>>> The commit b38747291d50 ("queue: break reg wait setup") just left this
>>> API definition with always "-EINVAL" result for building test.
>>>
>>> And new API 'io_uring_submit_and_wait_reg' has been implemented.
>>
>> You can't just remove symbols from a previously released
>> version of the library...
> 
> Cna only remove during the development cycle ?

Once a symbol is in a released version, it can't go away or you'd
break both compile and runtime use of it. The only symbols that can get
modified/removed are the ones that haven't been released yet, which
right now would be the 2.10 symbols.

-- 
Jens Axboe

Re: [PATCH liburing v1] register: Remove old API io_uring_register_wait_reg

[Haiyue Wang]

On 2025/5/17 22:33, Jens Axboe wrote:
> On 5/17/25 8:31 AM, Haiyue Wang wrote:
>>
>>
>> On 2025/5/17 22:20, Jens Axboe wrote:
>>> On 5/17/25 8:07 AM, Haiyue Wang wrote:
>>>> The commit b38747291d50 ("queue: break reg wait setup") just left this
>>>> API definition with always "-EINVAL" result for building test.
>>>>
>>>> And new API 'io_uring_submit_and_wait_reg' has been implemented.
>>>
>>> You can't just remove symbols from a previously released
>>> version of the library...
>>
>> Cna only remove during the development cycle ?
> 
> Once a symbol is in a released version, it can't go away or you'd
> break both compile and runtime use of it. The only symbols that can get
> modified/removed are the ones that haven't been released yet, which
> right now would be the 2.10 symbols.
Oh, got it, thanks.
>