From: Ammar Faizi <[email protected]>
To: Keith Busch <[email protected]>
Cc: Dylan Yudaken <[email protected]>, Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing] Alphabetise the test list
Date: Wed, 9 Nov 2022 15:53:05 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <Y2qdkSw4h/AXw3lZ@kbusch-mbp>
On 11/9/22 1:18 AM, Keith Busch wrote:
> On Tue, Nov 08, 2022 at 09:21:37AM -0800, Dylan Yudaken wrote:
>> Alphabetical order is commanded by the comment at the top of the list
>
> We could create a make target to detect this kind of thing. A quick
> script off the top of my head gets pretty close to finding improper
> order, though not sure how pedantic it needs to be with the dashes '-'.
>
> $ diff -u <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g') \
> <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g' | sort)
Good idea, we can also do this checking in our CI.
--
Ammar Faizi
prev parent reply other threads:[~2022-11-09 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 17:21 [PATCH liburing] Alphabetise the test list Dylan Yudaken
2022-11-08 17:34 ` Ammar Faizi
2022-11-08 17:35 ` Jens Axboe
2022-11-08 18:18 ` Keith Busch
2022-11-09 8:53 ` Ammar Faizi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox