From: Pavel Begunkov <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: Christian Brauner <[email protected]>,
[email protected], Dave Chinner <[email protected]>,
[email protected], "Darrick J . Wong" <[email protected]>,
[email protected], wu lei <[email protected]>
Subject: Re: [PATCH v2 1/1] iomap: propagate nowait to block layer
Date: Tue, 4 Mar 2025 17:54:51 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/4/25 16:59, Christoph Hellwig wrote:
> On Tue, Mar 04, 2025 at 04:41:40PM +0000, Pavel Begunkov wrote:
>> bio_iov_vecs_to_alloc() can overestimate, i.e. the check might return
>> -EAGAIN in more cases than required but not the other way around,
>> that should be enough for a fix such as this patch. Or did I maybe
>> misunderstood you?
>
> No you didn;t but we need to do this properly.
>
>> Assuming you're suggesting to implement that, I can't say I'm excited by
>> the idea of reworking a non trivial chunk of block layer to fix a problem
>> and then porting it up to some 5.x, especially since it was already
>> attempted before by someone and ultimately got reverted.
>
> Stop whining. Backporting does not matter for upstream development,
> and I'm pretty sure you'd qualify for a job where you don't have to do
> this if you actually care and don't just like to complain.
That's an interesting choice of words. Dear Christoph, I'm afraid you
don't realise that you're the one whining at a person who actually tries
to fix it. I'd appreciate if you stop this bullshit, especially if you're
not willing to fix it yourself. If you do, please, be my guest and prove
me wrong.
Stable does exist, and people do care about it, and people do care about
problems being fixed and not delayed because your desire for someone else
to do some random grand rework for you. If there are _actual_ problems
with the patch, please let me know. Some of more rare cases being not
as efficient is not a problem.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-03-04 17:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 12:18 [PATCH v2 1/1] iomap: propagate nowait to block layer Pavel Begunkov
2025-03-04 16:07 ` Christoph Hellwig
2025-03-04 16:41 ` Pavel Begunkov
2025-03-04 16:59 ` Christoph Hellwig
2025-03-04 17:36 ` Jens Axboe
2025-03-04 23:26 ` Christoph Hellwig
2025-03-04 23:43 ` Jens Axboe
2025-03-04 23:49 ` Christoph Hellwig
2025-03-05 0:14 ` Pavel Begunkov
2025-03-05 0:18 ` Pavel Begunkov
2025-03-04 17:54 ` Pavel Begunkov [this message]
2025-03-04 23:28 ` Christoph Hellwig
2025-03-04 19:22 ` Darrick J. Wong
2025-03-04 20:35 ` Pavel Begunkov
2025-03-05 0:01 ` Christoph Hellwig
2025-03-05 0:45 ` Pavel Begunkov
2025-03-05 1:34 ` Christoph Hellwig
2025-03-04 21:11 ` Dave Chinner
2025-03-04 22:47 ` Pavel Begunkov
2025-03-04 23:40 ` Christoph Hellwig
2025-03-05 1:19 ` Dave Chinner
2025-03-05 14:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox