public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: mark reissue requests with REQ_F_PARTIAL_IO
@ 2022-06-20 12:41 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2022-06-20 12:41 UTC (permalink / raw)
  To: io-uring; +Cc: Pavel Begunkov

If we mark for reissue, we assume that the buffer will remain stable.
Hence if are using a provided buffer, we need to ensure that we stick
with it for the duration of that request.

This only affects block devices that use provided buffers, as those are
the only ones that get marked with REQ_F_REISSUE.

Signed-off-by: Jens Axboe <[email protected]>

---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index d3ee4fc532fa..87c65a358678 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3437,7 +3437,7 @@ static bool __io_complete_rw_common(struct io_kiocb *req, long res)
 	if (unlikely(res != req->cqe.res)) {
 		if ((res == -EAGAIN || res == -EOPNOTSUPP) &&
 		    io_rw_should_reissue(req)) {
-			req->flags |= REQ_F_REISSUE;
+			req->flags |= REQ_F_REISSUE | REQ_F_PARTIAL_IO;
 			return true;
 		}
 		req_set_fail(req);
@@ -3487,7 +3487,7 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res)
 		kiocb_end_write(req);
 	if (unlikely(res != req->cqe.res)) {
 		if (res == -EAGAIN && io_rw_should_reissue(req)) {
-			req->flags |= REQ_F_REISSUE;
+			req->flags |= REQ_F_REISSUE | REQ_F_PARTIAL_IO;
 			return;
 		}
 		req->cqe.res = res;

-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-20 12:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-20 12:41 [PATCH] io_uring: mark reissue requests with REQ_F_PARTIAL_IO Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox