From: Haiyue Wang <haiyue.wang@cloudprime.ai>
To: io-uring@vger.kernel.org
Cc: Haiyue Wang <haiyue.wang@cloudprime.ai>
Subject: [PATCH liburing v2 5/6] test/reg-wait: use uring_ptr_to_u64() helper to convert ptr to u64
Date: Wed, 18 Jun 2025 18:55:42 +0800 [thread overview]
Message-ID: <8308685C708DC395+20250618110034.30904-6-haiyue.wang@cloudprime.ai> (raw)
In-Reply-To: <20250618110034.30904-1-haiyue.wang@cloudprime.ai>
Use the helper to handle type convertions, instead of two type
convertions by hand: '(__u64) (unsigned long)'.
Signed-off-by: Haiyue Wang <haiyue.wang@cloudprime.ai>
---
test/reg-wait.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/test/reg-wait.c b/test/reg-wait.c
index 01d5e8f..af517a1 100644
--- a/test/reg-wait.c
+++ b/test/reg-wait.c
@@ -219,10 +219,10 @@ static int test_wait_arg(void)
return T_EXIT_FAIL;
}
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
rd.size = page_size;
rd.flags = IORING_MEM_REGION_TYPE_USER;
- mr.region_uptr = (__u64)(unsigned long)&rd;
+ mr.region_uptr = uring_ptr_to_u64(&rd);
mr.flags = IORING_MEM_REGION_REG_WAIT_ARG;
ret = io_uring_register_region(&ring, &mr);
@@ -287,11 +287,11 @@ static int test_regions(void)
return T_EXIT_FAIL;
}
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
rd.size = page_size;
rd.flags = IORING_MEM_REGION_TYPE_USER;
- mr.region_uptr = (__u64)(unsigned long)&rd;
+ mr.region_uptr = uring_ptr_to_u64(&rd);
mr.flags = IORING_MEM_REGION_REG_WAIT_ARG;
ret = test_try_register_region(&mr, true);
@@ -324,7 +324,7 @@ static int test_regions(void)
fprintf(stderr, "test_try_register_region() null uptr fail %i\n", ret);
return T_EXIT_FAIL;
}
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
rd.flags = 0;
ret = test_try_register_region(&mr, true);
@@ -348,7 +348,7 @@ static int test_regions(void)
fprintf(stderr, "test_try_register_region() NULL region %i\n", ret);
return T_EXIT_FAIL;
}
- mr.region_uptr = (__u64)(unsigned long)&rd;
+ mr.region_uptr = uring_ptr_to_u64(&rd);
rd.user_addr += 16;
ret = test_try_register_region(&mr, true);
@@ -363,7 +363,7 @@ static int test_regions(void)
fprintf(stderr, "test_try_register_region() bogus uptr %i\n", ret);
return T_EXIT_FAIL;
}
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
free(buffer);
buffer = mmap(NULL, page_size, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
@@ -372,7 +372,7 @@ static int test_regions(void)
return 1;
}
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
ret = test_try_register_region(&mr, true);
if (ret != -EFAULT) {
fprintf(stderr, "test_try_register_region() RO uptr %i\n", ret);
@@ -393,7 +393,7 @@ static int test_regions(void)
has_kernel_regions = true;
rd.flags = 0;
- rd.user_addr = (__u64)(unsigned long)buffer;
+ rd.user_addr = uring_ptr_to_u64(buffer);
ret = test_try_register_region(&mr, true);
if (!ret) {
fprintf(stderr, "test_try_register_region() failed uptr w kernel alloc %i\n", ret);
@@ -421,7 +421,7 @@ static int t_region_create_kernel(struct t_region *r,
{
struct io_uring_region_desc rd = { .size = r->size, };
struct io_uring_mem_region_reg mr = {
- .region_uptr = (__u64)(unsigned long)&rd,
+ .region_uptr = uring_ptr_to_u64(&rd),
.flags = IORING_MEM_REGION_REG_WAIT_ARG,
};
void *p;
@@ -458,9 +458,9 @@ static int t_region_create_user(struct t_region *r,
if (p == MAP_FAILED)
return -ENOMEM;
- mr.region_uptr = (__u64)(unsigned long)&rd;
+ mr.region_uptr = uring_ptr_to_u64(&rd);
mr.flags = IORING_MEM_REGION_REG_WAIT_ARG;
- rd.user_addr = (__u64)(unsigned long)p;
+ rd.user_addr = uring_ptr_to_u64(p);
rd.flags = IORING_MEM_REGION_TYPE_USER;
rd.size = r->size;
--
2.49.0
next prev parent reply other threads:[~2025-06-18 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250618110034.30904-1-haiyue.wang@cloudprime.ai>
2025-06-18 10:55 ` [PATCH liburing v2 1/6] Add uring_ptr_to_u64() helper Haiyue Wang
2025-06-18 16:05 ` Jens Axboe
2025-06-18 10:55 ` [PATCH liburing v2 2/6] liburing: use uring_ptr_to_u64() helper to convert ptr to u64 Haiyue Wang
2025-06-18 10:55 ` [PATCH liburing v2 3/6] examples/reg-wait: " Haiyue Wang
2025-06-18 10:55 ` [PATCH liburing v2 4/6] examples/zcrx: " Haiyue Wang
2025-06-18 10:55 ` Haiyue Wang [this message]
2025-06-18 10:55 ` [PATCH liburing v2 6/6] test/zcrx: " Haiyue Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8308685C708DC395+20250618110034.30904-6-haiyue.wang@cloudprime.ai \
--to=haiyue.wang@cloudprime.ai \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox