From: Jens Axboe <axboe@kernel.dk>
To: Anuj gupta <anuj1072538@gmail.com>,
Nitesh Shetty <nj.shetty@samsung.com>
Cc: io-uring@vger.kernel.org, gost.dev@samsung.com, nitheshshetty@gmail.com
Subject: Re: [PATCH liburing 3/3] test/fixed-seg: Support non 512 LBA format devices.
Date: Wed, 23 Apr 2025 14:02:29 -0600 [thread overview]
Message-ID: <8380162d-98a1-4871-a0a2-608aed035c66@kernel.dk> (raw)
In-Reply-To: <CACzX3AtPziqFXmFvysyfCSLuZhGzppxs7k1WbHgrQweSn7V_zw@mail.gmail.com>
On 4/23/25 1:05 PM, Anuj gupta wrote:
>> + ioctl(fd, BLKSSZGET, &vec_off);
>
> nit: vec_off might be better named as block_size or lba_size to better
> reflect its use
Agree, and would be nice to have an error check on ioctl as
well, just to be prudent.
I'll apply this series as-is, as it's mostly just nits.
--
Jens Axboe
next prev parent reply other threads:[~2025-04-23 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250423133628epcas5p2b4752a672a64bd2f1392f663a284f9f2@epcas5p2.samsung.com>
2025-04-23 13:27 ` [PATCH liburing 0/3] test/fixed-seg: Add data verification and Nitesh Shetty
[not found] ` <CGME20250423133638epcas5p34a9cf20f13387f7f604d9c2e2bf6976a@epcas5p3.samsung.com>
2025-04-23 13:27 ` [PATCH liburing 1/3] test/fixed-seg: Prep patch, rename the vec to rvec Nitesh Shetty
[not found] ` <CGME20250423133642epcas5p1bef7e3af23bd8561f359ccc16fdaf980@epcas5p1.samsung.com>
2025-04-23 13:27 ` [PATCH liburing 2/3] test/fixed-seg: verify the data read Nitesh Shetty
[not found] ` <CGME20250423133646epcas5p2e67808b13c6c85444b8a9f28995fe70b@epcas5p2.samsung.com>
2025-04-23 13:27 ` [PATCH liburing 3/3] test/fixed-seg: Support non 512 LBA format devices Nitesh Shetty
2025-04-23 19:05 ` Anuj gupta
2025-04-23 20:02 ` Jens Axboe [this message]
2025-04-23 20:04 ` [PATCH liburing 0/3] test/fixed-seg: Add data verification and Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8380162d-98a1-4871-a0a2-608aed035c66@kernel.dk \
--to=axboe@kernel.dk \
--cc=anuj1072538@gmail.com \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox