From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH] io_uring: fix invalid handler for double apoll
Date: Sun, 25 Oct 2020 12:42:51 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/25/20 10:24 AM, Pavel Begunkov wrote:
> On 25/10/2020 15:53, Jens Axboe wrote:
>> On 10/25/20 8:26 AM, Pavel Begunkov wrote:
>>> io_poll_double_wake() is called for both: poll requests and as apoll
>>> (internal poll to make rw and other requests), hence when it calls
>>> __io_async_wake() it should use a right callback depending on the
>>> current poll type.
>>
>> Can we do something like this instead? Untested...
>
> It should work, but looks less comprehensible. Though, it'll need
Not sure I agree, with a comment it'd be nicer imho:
/* call appropriate handler for this request type */
poll->wait.func(wait, mode, sync, key);
instead of having to manually dig at the opcode to figure out which one
to use.
--
Jens Axboe
next prev parent reply other threads:[~2020-10-25 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 14:26 [PATCH] io_uring: fix invalid handler for double apoll Pavel Begunkov
2020-10-25 15:53 ` Jens Axboe
2020-10-25 16:24 ` Pavel Begunkov
2020-10-25 18:42 ` Jens Axboe [this message]
2020-10-25 19:01 ` Pavel Begunkov
2020-10-25 19:18 ` Jens Axboe
2020-10-25 19:32 ` Pavel Begunkov
2020-10-25 19:44 ` Jens Axboe
2020-10-25 19:54 ` Pavel Begunkov
2020-10-26 1:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox