From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3466617597 for ; Mon, 14 Apr 2025 14:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744640980; cv=none; b=YkiPyQft77mY2ZJlOx3LZmVTIFFW41sujTn3CeguXtQw2yUerwdNgheRrNqde+H+uwmYAcuoBZonDSaHLFcHX+e3zmBaLjfmPq1ULv26BPbrJ1gpXA4zAJlQxK8+goAco5HQajAB3gW82a6Kbm6OZf06O9sKkTfbjYNtng+is8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744640980; c=relaxed/simple; bh=xrn5wfYhTrS14m3EcQUIIlXCmc+aQ3BjPvdH9k2BM7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q5IoPnkGi8zQmtUbWhE8nbNqi130lGurix0SpvWfZfF/MgjmWbVrussDKC0ujL6nOJ2P7DinHntNQR7bY3bHhxRFjNYOGAcJ9zlCEki0H3AHqJdmOzZS7N/Q74GgJq6kF2wktZcOBOmn7YCeq4M59G01gxY/QcApbYtxsIKoePg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=W6FdC4D/; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="W6FdC4D/" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3d5e43e4725so14785975ab.1 for ; Mon, 14 Apr 2025 07:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1744640977; x=1745245777; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+1yYu8yQXLwEhLZXB69bga+C1rfzPofidjpYU39w4VI=; b=W6FdC4D/EtDU6mrXG8WyvRLIs/9PNzhOHxSEI89kNCJsqZCTmjpI7oEH8stZsujaES LyKAYzIeG/LNi0GGbr10EaYNNl/7Bwwmvon4Z62Le9vhc/sKbB9zwA5uXbsTRCxtWVKx ZXIPgF9+ydIw1JOlH2OjI6gugVNHIZ0h9eO4dxuMnbaxyhR6s9ffMkiFjdWysOg6yj40 fabMhtxrjXvQKme11XnK3B3FXNPGCKojgUG4t/v7ziriPkdPoXjwMinvLl6M5iP+iNu0 u9zzZxvq8h6xk8fkDwox0V+MwxmlHpgU+HBowaj+jm0uNKfjaIbu6VgpuOOTDjvu+Ry1 Z3RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744640977; x=1745245777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+1yYu8yQXLwEhLZXB69bga+C1rfzPofidjpYU39w4VI=; b=sR3EO3CqHohuNdqRUdQPvm7bV0EUBd1tw+1ieYig6PFJc+rpZC4dnBwwNsqKIu6mca nAIUOcwUIx/aAVp50as5+fYtjsyIgBO8dIyGoxr4DYiIyLHNrg7eOb9LyZgXi+TPQM9M edSInxQ1fhVCiX/+AXNIyI7r0K52ry1LXnjlszYsEdAwbPebgel1pDmsVUzUTVa4Jmsj VVtzHrXrA9cYgY1KnjCwD9xvsFpuXVswTzhc8aRTyOKY5k6+STFMY6sF0HsBfUgq9KW3 E4Lfhgaw0BAvxE9ZW1Qr0IDW554UF0uX/trccqeDBjeacJf5oNUSf6elB7l8HKhVAPBO ZkwA== X-Gm-Message-State: AOJu0YyhIyuDdVWMH5ZJrxVSKk5+27x42DdsBscUneRVj2svE+iJFLKR nbGhJAkvSXs1glAdy9SYcOb1j8cI2HXav3lgWW49Q4aE5G5vfWqjD3GCaespS2s= X-Gm-Gg: ASbGncvNRx/FHUUERCxdK/863zW3E6zONL+ykFzqKb9yjhltwvssT2YPWrpSvxaY6pd 2Ftkp3OVoRz02OzZzrmVaj7gamNDP4dn2Y0kUtgzU15bURGIpYonVcN13FsD5KuWTA8vYirAHkA VJDS8oGemOCt8y3o+eWO9w96Z8YwOH52jeX+XtBeb6FSVzd4J50lJEeKPpklef2XslYpeWVDkKS hYi4YGQFHY7oA0bedynUUZE+42tFFbkO2xZgppfSy/rVgyhbBnyxjy1n7m0owXWtSF+ZnEHabb1 k/3aFdrL3RI17W8Mxs2ZMYePuDDacgmlaL1KSw== X-Google-Smtp-Source: AGHT+IHgTb9OceURQXdiw9lwy+AMm5msOzwoMDpCHAEMkovZJ6nZ8AbWOE6ZRjIkVixcOUjTYcnLQQ== X-Received: by 2002:a05:6e02:3f05:b0:3d1:966c:fc8c with SMTP id e9e14a558f8ab-3d7ec27c9a3mr124172185ab.17.1744640977074; Mon, 14 Apr 2025 07:29:37 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d7dba85487sm27743155ab.23.2025.04.14.07.29.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 07:29:35 -0700 (PDT) Message-ID: <85587075-1d54-4b79-94d4-39f615eeee24@kernel.dk> Date: Mon, 14 Apr 2025 08:29:35 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] fs: gate final fput task_work on PF_NO_TASKWORK To: Christian Brauner Cc: io-uring@vger.kernel.org, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org References: <20250409134057.198671-1-axboe@kernel.dk> <20250409134057.198671-2-axboe@kernel.dk> <20250411-teebeutel-begibt-7d9c0323954b@brauner> <87fcae79-674c-4eea-8e65-4763c6fced44@kernel.dk> <20250414-unwiderruflich-daheim-8e14b89e7845@brauner> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250414-unwiderruflich-daheim-8e14b89e7845@brauner> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/14/25 4:10 AM, Christian Brauner wrote: > On Fri, Apr 11, 2025 at 08:37:51AM -0600, Jens Axboe wrote: >> On 4/11/25 7:48 AM, Christian Brauner wrote: >>> Seems fine. Although it has some potential for abuse. So maybe a >>> VFS_WARN_ON_ONCE() that PF_NO_TASKWORK is only used with PF_KTHREAD >>> would make sense. >> >> Can certainly add that. You'd want that before the check for >> in_interrupt and PF_NO_TASKWORK? Something ala >> >> /* PF_NO_TASKWORK should only be used with PF_KTHREAD */ >> VFS_WARN_ON_ONCE((task->flags & PF_NO_TASKWORK) && !(task->flags & PF_KTHREAD)); >> >> ? > > Yeah, sounds good! I used the usual XOR trick for this kind of test, but placed in the same spot: https://git.kernel.dk/cgit/linux/commit/?h=io_uring-exit-cancel.2&id=d5ab108781ccc2f0f013fe009a010a1f29a4785d -- Jens Axboe