From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <io-uring-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 876D7C88CB2
	for <io-uring@archiver.kernel.org>; Mon, 12 Jun 2023 13:48:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236659AbjFLNsA (ORCPT <rfc822;io-uring@archiver.kernel.org>);
        Mon, 12 Jun 2023 09:48:00 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37932 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236646AbjFLNrw (ORCPT
        <rfc822;io-uring@vger.kernel.org>); Mon, 12 Jun 2023 09:47:52 -0400
Received: from out-50.mta0.migadu.com (out-50.mta0.migadu.com [IPv6:2001:41d0:1004:224b::32])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67B74199C
        for <io-uring@vger.kernel.org>; Mon, 12 Jun 2023 06:47:46 -0700 (PDT)
Message-ID: <85a0bfd6-5e7b-0599-0f7f-96604bfce160@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
        t=1686577664;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=uL6XwpQ3XgfJMzir+1WHSrYFYcgtPiHvXWJTPW9MYrU=;
        b=NBeGcysWRmuFgFnbqWG9Zv+R+8/TnPW13gGlhvKccq3OZPH07gioDxYxXkOUXsfa4xZh7l
        tnUFaEP0QHFo+zlKyg8T+NGSklSBuhj59VdrD9pL9TzhTn3NLpsxNisH2htPdfcnxaWp20
        LxKGvPfMQWSCaujeQtyieIbCA2JZrpI=
Date:   Mon, 12 Jun 2023 21:47:40 +0800
MIME-Version: 1.0
Subject: Re: [PATCH 07/11] io_uring: add new api to register fixed workers
Content-Language: en-US
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Linux Fsdevel Mailing List <linux-fsdevel@vger.kernel.org>,
        io-uring Mailing List <io-uring@vger.kernel.org>
References: <20230609122031.183730-1-hao.xu@linux.dev>
 <20230609122031.183730-8-hao.xu@linux.dev>
 <ZIMvKkZZzAfVLGbj@biznet-home.integral.gnuweeb.org>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From:   Hao Xu <hao.xu@linux.dev>
In-Reply-To: <ZIMvKkZZzAfVLGbj@biznet-home.integral.gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT
Precedence: bulk
List-ID: <io-uring.vger.kernel.org>
X-Mailing-List: io-uring@vger.kernel.org

On 6/9/23 21:54, Ammar Faizi wrote:
> On Fri, Jun 09, 2023 at 08:20:27PM +0800, Hao Xu wrote:
>> +static __cold int io_register_iowq_fixed_workers(struct io_ring_ctx *ctx,
>> +					       void __user *arg, int nr_args)
>> +	__must_hold(&ctx->uring_lock)
>> +{
>> +	struct io_uring_task *tctx = NULL;
>> +	struct io_sq_data *sqd = NULL;
>> +	struct io_uring_fixed_worker_arg *res;
>> +	size_t size;
>> +	int i, ret;
>> +	bool zero = true;
>> +
>> +	size = array_size(nr_args, sizeof(*res));
>> +	if (size == SIZE_MAX)
>> +		return -EOVERFLOW;
>> +
>> +	res = memdup_user(arg, size);
>> +	if (IS_ERR(res))
>> +		return PTR_ERR(res);
>> +
>> +	for (i = 0; i < nr_args; i++) {
>> +		if (res[i].nr_workers) {
>> +			zero = false;
>> +			break;
>> +		}
>> +	}
>> +
>> +	if (zero)
>> +		return 0;
> 
> You have a memory leak bug here. The memdup_user() needs clean up.
> kfree(res);
> 

True, I'll fix it in v2, thanks.