From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F08C35647 for ; Fri, 21 Feb 2020 13:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DF8020578 for ; Fri, 21 Feb 2020 13:52:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eR4hFprq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727876AbgBUNwr (ORCPT ); Fri, 21 Feb 2020 08:52:47 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:37974 "EHLO mail-wm1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728255AbgBUNwr (ORCPT ); Fri, 21 Feb 2020 08:52:47 -0500 Received: by mail-wm1-f43.google.com with SMTP id a9so1964946wmj.3 for ; Fri, 21 Feb 2020 05:52:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lRPHSgjx7C79Ssl0bxinfSoXqKoWtNghKGVkMYGeI1M=; b=eR4hFprqF4S4IY4IurbRvvS6Cz8BHQiHo3dobgwvij2OJ26+xAuKJneh+LbWJOjvTq WgXkdsKzLWYo/Y1GsrshmoAuXgR4i0YyySu7uiKQG6Wz+NI367QnGiJzH2Xu0U/cL+XU MAuByeGb+ovrZwXP1n/mJcfH5FvAUAWDLgQt+hp/Th0iLNDHilSoWLiJRb97LG9gbmOb tSpl8kJwYu9Bed/s2mB2tnP1b9OfOL+ITC2dEUSQF6XCtgb5HT26qIDylXEZdXKldfM2 9hv0qtdr/cNOA4dA5yoJAAUQkQ9qdwTzXTS9liQ535F1rLRqy7u/RzaaTA+h4Vcw4apH xcKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lRPHSgjx7C79Ssl0bxinfSoXqKoWtNghKGVkMYGeI1M=; b=sH7ZX8xP0yprBXvahpmFeZIbiYAeISB63nHZbbkkpCb/yuPZy/6+Ko+7B309RmlXMl mGZEp3r3Y79JYl1OOCGfs084dAn90lgiBpPxxoxoSBYRvBDBqsYI4e5y/N06oO+MFTZn KzEXjx+7nu3fLC4rzlD9OUsla6u2C/BuaHvKwm07nu1KALp0Hxg3wBuRM67VijUo8zgv bO/uAIU5I0mq1xZBDauD1owqMMkfBXt4dU2Fc0OyOWcFJP/jayyaRCe8tFEkhQt0RqCs vaO3cyXhekDxM7mgAqPXEM2PYVv7iQyCeMDDBT8etM/yNPsiyVABSthoXmsAslEZQcej KLmQ== X-Gm-Message-State: APjAAAVvZv0RpV2c15NgMG1qOMy6OPoZ90DQhnFJ14orpbQtpRO0UXec eu5VMM0j05DFMYRmHdYi6Cs= X-Google-Smtp-Source: APXvYqyQuF5ri8AiZ4OZx1KBAh7UdiyZd7f2bgHN8H/41WzHfQpoW3RTPAhNeTWZwuqLfGBedy/TRQ== X-Received: by 2002:a1c:6085:: with SMTP id u127mr4243072wmb.144.1582293163962; Fri, 21 Feb 2020 05:52:43 -0800 (PST) Received: from [192.168.43.74] ([109.126.129.28]) by smtp.gmail.com with ESMTPSA id c141sm3665126wme.41.2020.02.21.05.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 05:52:43 -0800 (PST) To: Jens Axboe , io-uring@vger.kernel.org Cc: glauber@scylladb.com, peterz@infradead.org, Jann Horn References: <20200220203151.18709-1-axboe@kernel.dk> <20200220203151.18709-8-axboe@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH 7/9] io_uring: add per-task callback handler Message-ID: <862fb96f-cebe-dfd8-0042-3284985d8704@gmail.com> Date: Fri, 21 Feb 2020 16:51:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200220203151.18709-8-axboe@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 20/02/2020 23:31, Jens Axboe wrote: > For poll requests, it's not uncommon to link a read (or write) after > the poll to execute immediately after the file is marked as ready. > Since the poll completion is called inside the waitqueue wake up handler, > we have to punt that linked request to async context. This slows down > the processing, and actually means it's faster to not use a link for this > use case. > > We also run into problems if the completion_lock is contended, as we're > doing a different lock ordering than the issue side is. Hence we have > to do trylock for completion, and if that fails, go async. Poll removal > needs to go async as well, for the same reason. > > eventfd notification needs special case as well, to avoid stack blowing > recursion or deadlocks. > > These are all deficiencies that were inherited from the aio poll > implementation, but I think we can do better. When a poll completes, > simply queue it up in the task poll list. When the task completes the > list, we can run dependent links inline as well. This means we never > have to go async, and we can remove a bunch of code associated with > that, and optimizations to try and make that run faster. The diffstat > speaks for itself. So, it piggybacks request execution onto a random task, that happens to complete a poll. Did I get it right? I can't find where it setting right mm, creds, etc., or why it have them already. -- Pavel Begunkov