From: Jens Axboe <[email protected]>
To: Xuan Zhuo <[email protected]>,
io-uring <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2] io_uring: fix io_sq_thread no schedule when busy
Date: Tue, 23 Jun 2020 11:54:51 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <bb5be3f3976e1c56f4bcc309ea417a20ea384853.1592912043.git.xuanzhuo@linux.alibaba.com>
On 6/23/20 5:34 AM, Xuan Zhuo wrote:
> When the user consumes and generates sqe at a fast rate,
> io_sqring_entries can always get sqe, and ret will not be equal to -EBUSY,
> so that io_sq_thread will never call cond_resched or schedule, and then
> we will get the following system error prompt:
>
> rcu: INFO: rcu_sched self-detected stall on CPU
> or
> watchdog: BUG: soft lockup-CPU#23 stuck for 112s! [io_uring-sq:1863]
>
> This patch checks whether need to call cond_resched() by checking
> the need_resched() function every cycle.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-06-23 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a932f437e5337cbfb42db660473fa55fa7aff9f6.1592804776.git.xuanzhuo@linux.alibaba.com>
2020-06-23 11:34 ` [PATCH v2] io_uring: fix io_sq_thread no schedule when busy Xuan Zhuo
2020-06-23 17:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox