From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
[email protected], [email protected]
Cc: Daurnimator <[email protected]>
Subject: Re: [PATCH v2 2/2] io_uring: add io-wq workqueue sharing
Date: Mon, 27 Jan 2020 17:22:02 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <c40338a9989a45ec38f36e5937365eca6a089795.1580170474.git.asml.silence@gmail.com>
On 1/27/20 5:15 PM, Pavel Begunkov wrote:
> @@ -6577,7 +6613,11 @@ static long io_uring_setup(u32 entries, struct io_uring_params __user *params)
>
> if (p.flags & ~(IORING_SETUP_IOPOLL | IORING_SETUP_SQPOLL |
> IORING_SETUP_SQ_AFF | IORING_SETUP_CQSIZE |
> - IORING_SETUP_CLAMP))
> + IORING_SETUP_CLAMP | IORING_SETUP_ATTACH_WQ))
> + return -EINVAL;
> +
> + /* wq_fd isn't valid without ATTACH_WQ being set */
> + if (!(p.flags & IORING_SETUP_ATTACH_WQ) && p.wq_fd)
> return -EINVAL;
Since we're now using file descriptors, this no longer works. Any values
(outside of -1) is fair game.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-28 0:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 0:06 [PATCH 0/2] io-wq sharing Pavel Begunkov
2020-01-28 0:06 ` [PATCH 1/2] io-wq: allow grabbing existing io-wq Pavel Begunkov
2020-01-28 0:06 ` [PATCH 2/2] io_uring: add io-wq workqueue sharing Pavel Begunkov
2020-01-28 0:08 ` [PATCH 0/2] io-wq sharing Pavel Begunkov
2020-01-28 0:15 ` [PATCH v2 " Pavel Begunkov
2020-01-28 0:15 ` [PATCH v2 1/2] io-wq: allow grabbing existing io-wq Pavel Begunkov
2020-01-28 0:18 ` Pavel Begunkov
2020-01-28 0:20 ` Jens Axboe
2020-01-28 0:15 ` [PATCH v2 2/2] io_uring: add io-wq workqueue sharing Pavel Begunkov
2020-01-28 0:22 ` Jens Axboe [this message]
2020-01-28 0:29 ` [PATCH v2 0/2] io-wq sharing Jens Axboe
2020-01-28 7:41 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox