public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Caleb Sander Mateos <[email protected]>,
	Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file
Date: Sat, 1 Mar 2025 01:46:57 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 3/1/25 00:16, Caleb Sander Mateos wrote:
> Declare io_find_buf_node() in io_uring/rsrc.h so it can be called from
> other files.
> 
> Signed-off-by: Caleb Sander Mateos <[email protected]>
> ---
>   io_uring/rsrc.c | 4 ++--
>   io_uring/rsrc.h | 2 ++
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
> index 45bfb37bca1e..4c4f57cd77f9 100644
> --- a/io_uring/rsrc.c
> +++ b/io_uring/rsrc.c
> @@ -1066,12 +1066,12 @@ static int io_import_fixed(int ddir, struct iov_iter *iter,
>   	}
>   
>   	return 0;
>   }
>   
> -static inline struct io_rsrc_node *io_find_buf_node(struct io_kiocb *req,
> -						    unsigned issue_flags)

That's a hot path, an extra function call wouldn't be great,
and it's an internal detail as well. Let's better see what we
can do with the nop situation.

btw, don't forget cover letters for series.

-- 
Pavel Begunkov


  parent reply	other threads:[~2025-03-01  1:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-01  0:16 [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file Caleb Sander Mateos
2025-03-01  0:16 ` [PATCH 2/2] io_uring/nop: use io_find_buf_node() Caleb Sander Mateos
2025-03-01  1:41   ` Pavel Begunkov
2025-03-01  1:58     ` Caleb Sander Mateos
2025-03-01  2:10       ` Jens Axboe
2025-03-01  2:11       ` Pavel Begunkov
2025-03-01  2:15     ` Pavel Begunkov
2025-03-01  2:21       ` Jens Axboe
2025-03-01  2:36         ` Pavel Begunkov
2025-03-01  2:39           ` Jens Axboe
2025-03-01  3:02             ` Pavel Begunkov
2025-03-01  1:46 ` Pavel Begunkov [this message]
2025-03-01  2:04   ` [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file Caleb Sander Mateos
2025-03-01  2:22     ` Jens Axboe
2025-03-01  2:31       ` Pavel Begunkov
2025-03-01  2:33         ` Jens Axboe
2025-03-01  2:23 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox