From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A2DC433DF for ; Fri, 16 Oct 2020 18:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FE08208E4 for ; Fri, 16 Oct 2020 18:03:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="WprMmSjc"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="/1McgWzP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390346AbgJPSDH (ORCPT ); Fri, 16 Oct 2020 14:03:07 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:46092 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387509AbgJPSDH (ORCPT ); Fri, 16 Oct 2020 14:03:07 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602871386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VjN47K1oRc9Uf/luZGiXWJiCGTO/s1PL6HhypKJDE2Q=; b=WprMmSjcUBCd+LqmcC2gB1CcFxwAHpvQBnJIdzVwBAT1qAekwpAU5Dbt25J8CJvIFGKYW7 tZML5GsXmAY2qY/kKMJpGwDwbuHxWjLqu7grCPxoklSBWJKZ4sYINii6dkXmQUwfOkL/xZ /kDKUD1o82xkRdQKQwLqRzozdLk72IqJcao0K7Ky2cJj81yT49YlLk0k7uuxWE4nl6nb0B xOTfoSjlWjaiZZyKHiFH7yy2PyEVdviIdlD6qwNiEgcrEMyhEiWhGNMNo168YsMlyrH7nj iYGBo4csD2L8Z9W+CuHmiRiy6CVI9kGiXV2cy2748L7aqjwF7w1Toa2Aiu057Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602871386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VjN47K1oRc9Uf/luZGiXWJiCGTO/s1PL6HhypKJDE2Q=; b=/1McgWzP+vZ+PGht2uWGHFsQMF0oMXXCvUssNI8fYGSNvuRHLoTIe5OxfRpLEMd4AH74Mf Dl6lmorJ3AhoSnCw== To: Jens Axboe , Oleg Nesterov Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, Roman Gershman Subject: Re: [PATCH 5/5] task_work: use TIF_NOTIFY_SIGNAL if available In-Reply-To: <1a89eacd-830e-7310-0e56-9b4b389cdc5d@kernel.dk> References: <20201015131701.511523-1-axboe@kernel.dk> <20201015131701.511523-6-axboe@kernel.dk> <20201015154953.GM24156@redhat.com> <87a6wmv93v.fsf@nanos.tec.linutronix.de> <871rhyv7a8.fsf@nanos.tec.linutronix.de> <87a6wmtfvb.fsf@nanos.tec.linutronix.de> <20201016145138.GB21989@redhat.com> <1a89eacd-830e-7310-0e56-9b4b389cdc5d@kernel.dk> Date: Fri, 16 Oct 2020 20:03:04 +0200 Message-ID: <874kmuaw13.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, Oct 16 2020 at 08:53, Jens Axboe wrote: > On 10/16/20 8:51 AM, Oleg Nesterov wrote: >> On 10/16, Thomas Gleixner wrote: >>> >>> With moving the handling into get_signal() you don't need more changes >>> to arch/* than adding the TIF bit, right? >> >> we still need to do something like >> >> - if (thread_flags & _TIF_SIGPENDING) >> + if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) >> do_signal(...); >> >> and add _TIF_NOTIFY_SIGNAL to the WORK-PENDING mask in arch/* code. > > Yes, but it becomes really minimal at that point, and just that. There's > no touching any of the arch do_signal() code. > > Just finished the update of the branch to this model, and it does simplify > things quite a bit! Most arch patches are now exactly just what you write > above, no more. Except for all the nasty ones which have these checks in ASM :)