From: Jens Axboe <[email protected]>
To: Keith Busch <[email protected]>, [email protected]
Cc: [email protected], Keith Busch <[email protected]>,
Linus Torvalds <[email protected]>
Subject: Re: [PATCH] fs: don't randomized kiocb fields
Date: Fri, 12 Aug 2022 17:00:18 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/12/22 4:56 PM, Keith Busch wrote:
> From: Keith Busch <[email protected]>
>
> This is a size sensitive structure and randomizing can introduce extra
> padding that breaks io_uring's fixed size expectations. There are few
> fields here as it is, half of which need a fixed order to optimally
> pack, so the randomization isn't providing much.
I'll add the link to the previous discussion as well in the commit:
Link: https://lore.kernel.org/io-uring/[email protected]/
as it's pretty useful for context.
--
Jens Axboe
next prev parent reply other threads:[~2022-08-12 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 22:56 [PATCH] fs: don't randomized kiocb fields Keith Busch
2022-08-12 23:00 ` Jens Axboe [this message]
2022-08-13 7:59 ` Christoph Hellwig
2022-08-13 14:33 ` Jens Axboe
2022-08-14 10:35 ` Matthew Wilcox
2022-08-15 14:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox