From: Gabriel Krisman Bertazi <[email protected]>
To: Markus Elfring <[email protected]>
Cc: [email protected], [email protected],
Hao Xu <[email protected]>, Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected], LKML <[email protected]>
Subject: Re: [cocci] [PATCH] io_uring: Fix exception handling in io_ring_ctx_alloc()
Date: Wed, 10 Jan 2024 13:55:53 -0300 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]> (Markus Elfring's message of "Wed, 29 Mar 2023 17:46:03 +0200")
Markus Elfring <[email protected]> writes:
> Date: Wed, 29 Mar 2023 17:35:16 +0200
>
> The label “err” was used to jump to a kfree() call despite of
> the detail in the implementation of the function “io_ring_ctx_alloc”
> that it was determined already that a corresponding variable contained
> a null pointer because of a failed memory allocation.
>
> 1. Thus use more appropriate labels instead.
>
> 2. Reorder jump targets at the end.
FWIW, I don't think it makes sense to have the extra labels or re-sort
without a good reason. kfree works fine with the NULL pointers, so there
is no bug to be fixed and moving code around for no reason just makes
life painful for backporters.
Also, the patch no longer applies.
> 3. Omit the statement “kfree(ctx->io_bl);”.
From a quick look, this might still make sense. can you confirm and make
that change into a separate patch?
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2024-01-10 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[email protected]>
[not found] ` <[email protected]>
2024-01-10 11:23 ` io_uring: Fix exception handling in io_ring_ctx_alloc() Markus Elfring
2024-01-10 16:55 ` Gabriel Krisman Bertazi [this message]
2024-01-10 20:45 ` [PATCH v2 0/2] io_uring: Adjustments for io_ring_ctx_alloc() Markus Elfring
2024-01-10 20:48 ` [PATCH v2 1/2] io_uring: Delete a redundant kfree() call in io_ring_ctx_alloc() Markus Elfring
2024-01-12 14:25 ` Gabriel Krisman Bertazi
2024-01-12 16:18 ` Jens Axboe
2024-01-12 17:15 ` Gabriel Krisman Bertazi
2024-01-12 17:50 ` [v2 " Markus Elfring
2024-01-10 20:50 ` [PATCH v2 2/2] io_uring: Improve exception handling " Markus Elfring
2024-01-11 13:23 ` Pavel Begunkov
2024-01-12 14:30 ` Gabriel Krisman Bertazi
2024-01-12 15:00 ` [v2 " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox