From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD92C2BA83 for ; Sun, 16 Feb 2020 17:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91D0720659 for ; Sun, 16 Feb 2020 17:15:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="FRpZhnw8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbgBPRPK (ORCPT ); Sun, 16 Feb 2020 12:15:10 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:37019 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727895AbgBPRPK (ORCPT ); Sun, 16 Feb 2020 12:15:10 -0500 Received: by mail-pj1-f66.google.com with SMTP id m13so6156673pjb.2 for ; Sun, 16 Feb 2020 09:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=j6In1ZMqVqL+EXVTCAEgQ5YhGd4Op+E9zTb7k2XCzGk=; b=FRpZhnw8jNA6iPn+w5/D3iYi1ElYXNSDUkzmilx+bQ8810Wz0XsMUPWIpRglmBTSft p1J0B7NTmshC0/phHwFPgJQONaaLwID7rNe63j4jleW1q4ISIGAVWFdQwOaewQFJ3h05 RIo0+dYlRtuFjVhme8xF9mRJH4fct1MRY2U8fKI4h1wuOJhbw5hULpeltMvv/cymeJos iozthv+J/tGd7RVI0fas8xHdn7wEuHzzY1H6aMB4szGs9E0Oz77YTeYCc0uA1VR0/BxW OKuS471grWaedWlOQ6RyjmEM7oCNYR1uj9bf63NEfm7Rcj2JH0abacbGSo86JIRGX7N1 Q6+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j6In1ZMqVqL+EXVTCAEgQ5YhGd4Op+E9zTb7k2XCzGk=; b=r5SA+pznxpbN4AJx22DUr2ovIvW2Qs9a92FPxyvtefih8rJK7TdW/POKqvkjY9Ewg/ auwghFDjcXVeE+StntwDgGmQQgK/6KAKvYeZj626avcFhcEZBavC9vPxJ4L4xBtWXU8B Cz2FwHQ9VhaGeM5haB0hJuzvEFXvoSznSX7MMhpcyIHJAPbcVrB0FAo8woaYPV3FKyWC iXExeOypXvB7qk/Lyv/QtjNVeGEIWxUZ5ogu+kaMlhtsGWeqng991o7xVMN6XOpFU2zB LFoM6rJ1mjDpYZuamfGM2uiHIjsssygkTACsmm2dr59YWU+i7IsHTHRGymPGAPdnnyHZ 2G5g== X-Gm-Message-State: APjAAAXZeU6i06iK14zhH/0j2x29uuEPJpFpHlg/D3E3cMyJeWMs+l8S 9Ru1x6lBOY6NKvKjxWUczhwRbw== X-Google-Smtp-Source: APXvYqz/BVLKj4CMP1lu96h4dUcFR62S1Rbi9mYMVUoHqq+uM7szXQCvmpzYtkur9nb8ngHltEpMGQ== X-Received: by 2002:a17:90a:b010:: with SMTP id x16mr16053385pjq.130.1581873307958; Sun, 16 Feb 2020 09:15:07 -0800 (PST) Received: from ?IPv6:2605:e000:100e:8c61:b1fd:20cc:c368:304b? ([2605:e000:100e:8c61:b1fd:20cc:c368:304b]) by smtp.gmail.com with ESMTPSA id x65sm14255050pfb.171.2020.02.16.09.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2020 09:15:07 -0800 (PST) Subject: Re: [PATCH v2 1/5] io_uring: add missing io_req_cancelled() To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <879b7984-c45b-6bf5-9e15-ee4b744e47f2@kernel.dk> Date: Sun, 16 Feb 2020 09:15:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/15/20 3:01 PM, Pavel Begunkov wrote: > fallocate_finish() is missing cancellation check. Add it. > It's safe to do that, as only flags setup and sqe fields copy are done > before it gets into __io_fallocate(). Thanks, I added this one to the 5.6 mix. Going to be sporadic this next week, but I hope I can get to your 5.7 material anyway. -- Jens Axboe