From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4645D2D97B7 for ; Tue, 21 Apr 2026 17:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791163; cv=none; b=qMrFgoH5+CQZVfG/66ssh520dzIQzhN1iO/elPJstvm0ION/CeomFrM91ayo7G8si2VenYZf6X0vNBEbv00lAFnIqWjcl3HLo2gER7quQIiXE8N6PD8Ou+eGciYMqgASScZ416bIpyXhopvC3WATh08lqNVUCcE7+9Z7n2Qm4Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791163; c=relaxed/simple; bh=9J2hhG7hQyH4WjUzo15EElH1On4YxLDKBrP7h1hnius=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JrYuo+X16joEQInG/QQrY9kt1gVHvHwK4+SVSQcIrsO1XiscsCio3xkl0yAE+MThvSg8gs7MPkNmNJCW4VDtu3cbI5knmD8VqN/Ypx5tPfMbKurWJQMKH6rzzU4EAQrTRrfM0U9ZykLk5JWF/z9SNpPp0dDP2mRjN3H5OoK5iMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=EF/j6KCE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g67/dli5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=EF/j6KCE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=g67/dli5; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EF/j6KCE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g67/dli5"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="EF/j6KCE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="g67/dli5" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5A4196A800; Tue, 21 Apr 2026 17:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776791160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/8XfR2fGigeSXwrRsos2Ar7zmITy/DxXvR2kYWRLMo=; b=EF/j6KCEBVJPSFEIajSFPn3yYxLZCobDByNekW0aXkdb3C67jfD2U2NQD8C5Q5iTkU8tXB A3P5CzGwaaFaqNaoRkzkJPAyoDcFiR/fXzSddU31ErtSMcx+rtrzLx/w/yJmMvAKKei7VP ZJYbOXvgTJmno11aLMW0KhtaVWGuLvI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776791160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/8XfR2fGigeSXwrRsos2Ar7zmITy/DxXvR2kYWRLMo=; b=g67/dli5qBm+gbyK6IRbZVfFTWjStn/Fcr1shnRi+yzScuhCS+K4YQOg8KZccDRpWBiR8o 8slWdQxHgxfasOBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="EF/j6KCE"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="g67/dli5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776791160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/8XfR2fGigeSXwrRsos2Ar7zmITy/DxXvR2kYWRLMo=; b=EF/j6KCEBVJPSFEIajSFPn3yYxLZCobDByNekW0aXkdb3C67jfD2U2NQD8C5Q5iTkU8tXB A3P5CzGwaaFaqNaoRkzkJPAyoDcFiR/fXzSddU31ErtSMcx+rtrzLx/w/yJmMvAKKei7VP ZJYbOXvgTJmno11aLMW0KhtaVWGuLvI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776791160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/8XfR2fGigeSXwrRsos2Ar7zmITy/DxXvR2kYWRLMo=; b=g67/dli5qBm+gbyK6IRbZVfFTWjStn/Fcr1shnRi+yzScuhCS+K4YQOg8KZccDRpWBiR8o 8slWdQxHgxfasOBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0A9AD593AF; Tue, 21 Apr 2026 17:05:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id C8wSMneu52nUYwAAD6G6ig (envelope-from ); Tue, 21 Apr 2026 17:05:59 +0000 From: Gabriel Krisman Bertazi To: Jens Axboe Cc: io-uring@vger.kernel.org Subject: Re: [PATCH 1/6] io_uring: fix spurious fput in registered ring path In-Reply-To: <20260421135626.581917-2-axboe@kernel.dk> (Jens Axboe's message of "Tue, 21 Apr 2026 07:51:38 -0600") References: <20260421135626.581917-1-axboe@kernel.dk> <20260421135626.581917-2-axboe@kernel.dk> Date: Tue, 21 Apr 2026 13:05:53 -0400 Message-ID: <87bjfcqm4u.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[kernel.dk:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 5A4196A800 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Jens Axboe writes: > Fix an issue with io_uring_ctx_get_file() not gating fput() on whether > or not the file descriptor is a registered/direct one or not. > > Fixes: c5e9f6a96bf7 ("io_uring: unify getting ctx from passed in file descriptor") > Signed-off-by: Jens Axboe Oh. Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi