Re: [PATCH 1/2] io_uring/kbuf: kill dead struct io_buffer_list 'nr_entries' member

[Gabriel Krisman Bertazi <krisman@suse.de>]

Jens Axboe <axboe@kernel.dk> writes:

> This is only ever assigned, never used. The only used part is the
> calculated mask, which is used for indexing. Kill 'nr_entries'.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>

Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>

> ---
>  io_uring/kbuf.c | 1 -
>  io_uring/kbuf.h | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c
> index 8da2ff798170..43e4f8615fe8 100644
> --- a/io_uring/kbuf.c
> +++ b/io_uring/kbuf.c
> @@ -680,7 +680,6 @@ int io_register_pbuf_ring(struct io_ring_ctx *ctx, void __user *arg)
>  	}
>  #endif
>  
> -	bl->nr_entries = reg.ring_entries;
>  	bl->mask = reg.ring_entries - 1;
>  	bl->flags |= IOBL_BUF_RING;
>  	bl->buf_ring = br;
> diff --git a/io_uring/kbuf.h b/io_uring/kbuf.h
> index bf15e26520d3..abf7052b556e 100644
> --- a/io_uring/kbuf.h
> +++ b/io_uring/kbuf.h
> @@ -27,7 +27,6 @@ struct io_buffer_list {
>  	__u16 bgid;
>  
>  	/* below is for ring provided buffers */
> -	__u16 nr_entries;
>  	__u16 head;
>  	__u16 mask;

-- 
Gabriel Krisman Bertazi