Re: [PATCH 2/2] io_uring: introduce IORING_OP_MMAP

[Gabriel Krisman Bertazi <krisman@suse.de>]

Jens Axboe <axboe@kernel.dk> writes:

> On 1/29/26 3:11 PM, Gabriel Krisman Bertazi wrote:
>
>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
>> index b5b23c0d5283..e24fe3b00059 100644
>> --- a/include/uapi/linux/io_uring.h
>> +++ b/include/uapi/linux/io_uring.h
>> @@ -74,6 +74,7 @@ struct io_uring_sqe {
>>  		__u32		install_fd_flags;
>>  		__u32		nop_flags;
>>  		__u32		pipe_flags;
>> +		__u32		mmap_flags;
>>  	};
>>  	__u64	user_data;	/* data to be passed back at completion time */
>>  	/* pack this to avoid bogus arm OABI complaints */
>> @@ -303,6 +304,7 @@ enum io_uring_op {
>>  	IORING_OP_PIPE,
>>  	IORING_OP_NOP128,
>>  	IORING_OP_URING_CMD128,
>> +	IORING_OP_MMAP,
>>  
>>  	/* this goes last, obviously */
>>  	IORING_OP_LAST,
>> @@ -1113,6 +1115,14 @@ struct zcrx_ctrl {
>>  	};
>>  };
>>  
>> +struct io_uring_mmap_desc {
>> +	void __user *addr;
>> +	unsigned long len;
>> +	unsigned long pgoff;
>> +	unsigned int prot;
>> +	unsigned int flags;
>> +};
>
> You can't use pointers or unsigned long or unsigned int in a uapi, as

Thanks for the review, Jens.

I went on vacation right after sending this, but I will follow up with a v2 shortly.

-- 
Gabriel Krisman Bertazi