From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FA5C6FD18 for ; Fri, 31 Mar 2023 13:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231775AbjCaNfO (ORCPT ); Fri, 31 Mar 2023 09:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232783AbjCaNfO (ORCPT ); Fri, 31 Mar 2023 09:35:14 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B9DB1EA23; Fri, 31 Mar 2023 06:35:13 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE3371F38C; Fri, 31 Mar 2023 13:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680269711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WBTTw4FmgIAb/cjVvDNfUQ4cZmC0+48pwsVLVqEzmQk=; b=djiMXrm6ONVzenkSncn2vz9NCUmPQaX1n+i5uNfcskIAo6tG8LAhsZ4/Rf61Xj1zteHzrn jvQqtgaUCqDHzxuMFsKtrhvtPcR+Jd+Ct3VEH+QgYS5TilNm0Dmw0pUmEPxbIlN4ptfG1K Nt91p8d6XJnNPu55RAyXhApzol+1b8w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680269711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WBTTw4FmgIAb/cjVvDNfUQ4cZmC0+48pwsVLVqEzmQk=; b=2iMsWtPSnK7zOBkPNEfgmRjP5tgL4KjAwhwhOmsj8P4JsKOfCB6aGVuoExsrJ+eqgbtL1X JMO1s2xo8wye3lBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DD6C133B6; Fri, 31 Mar 2023 13:35:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OHjiDY/hJmQ7TQAAMHmgww (envelope-from ); Fri, 31 Mar 2023 13:35:11 +0000 From: Gabriel Krisman Bertazi To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [RFC 00/11] optimise registered buffer/file updates References: Date: Fri, 31 Mar 2023 10:35:09 -0300 In-Reply-To: (Pavel Begunkov's message of "Thu, 30 Mar 2023 15:53:18 +0100") Message-ID: <87h6u111te.fsf@suse.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Pavel, Pavel Begunkov writes: > Updating registered files and buffers is a very slow operation, which > makes it not feasible for workloads with medium update frequencies. > Rework the underlying rsrc infra for greater performance and lesser > memory footprint. > > The improvement is ~11x for a benchmark updating files in a loop > (1040K -> 11468K updates / sec). Nice. That's a really impressive improvement. I've been adding io_uring test cases for automated performance regression testing with mmtests (open source). I'd love to take a look at this test case and adapt it to mmtests, so we can pick it up and run it frequently. is it something you can share? -- Gabriel Krisman Bertazi