Re: [PATCH] io_uring/cmd_net: fix too strict requirement on ioctl

[Gabriel Krisman Bertazi <krisman@suse.de>]

Asbjørn Sloth Tønnesen <ast@fiberby.net> writes:

> Attempting SOCKET_URING_OP_SETSOCKOPT on an AF_NETLINK socket resulted
> in an -EOPNOTSUPP, as AF_NETLINK doesn't have an ioctl in its struct
> proto, but only in struct proto_ops.
>
> Prior to the blamed commit, io_uring_cmd_sock() only had two cmd_op
> operations, both requiring ioctl, thus the check was warranted.
>
> Since then, 4 new cmd_op operations have been added, none of which
> depend on ioctl. This patch moves the ioctl check, so it only applies
> to the original operations.
>
> AFAICT, the ioctl requirement was unintentional, and it wasn't
> visible in the blamed patch within 3 lines of context.
>
> Cc: stable@vger.kernel.org
> Fixes: a5d2f99aff6b ("io_uring/cmd: Introduce SOCKET_URING_OP_GETSOCKOPT")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>


-- 
Gabriel Krisman Bertazi