Re: [PATCH v3 3/3] io_uring: Introduce getsockname io_uring cmd

[Gabriel Krisman Bertazi <krisman@suse.de>]

Stefan Metzmacher <metze@samba.org> writes:

> Hi Gabriel,
>
>> +static int io_uring_cmd_getsockname(struct socket *sock,
>> +				    struct io_uring_cmd *cmd,
>> +				    unsigned int issue_flags)
>> +{
>> +	const struct io_uring_sqe *sqe = cmd->sqe;
>> +	struct sockaddr __user *uaddr;
>> +	unsigned int peer;
>> +	int __user *ulen;
>> +
>> +	if (sqe->ioprio || sqe->__pad1 || sqe->len || sqe->rw_flags)
>> +		return -EINVAL;
>> +
>> +	uaddr = u64_to_user_ptr(READ_ONCE(sqe->addr));
>> +	ulen = u64_to_user_ptr(sqe->addr3);
>> +	peer = READ_ONCE(sqe->optlen);
>> +	if (peer > 1)
>> +		return -EINVAL;
>> +	return do_getsockname(sock, 0, uaddr, ulen);
>
> I guess this should actually pass down 'peer' instead of '0'?

Thanks for the catch.  I guess two wrongs *do* make a right somethings.
The getpeername test was peeking at the wrong socket, effectively
testing the local port against itself, and it thus succeeded. Updated
the test and will send a v4.

-- 
Gabriel Krisman Bertazi