From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2BDC43334 for ; Wed, 20 Jul 2022 16:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234775AbiGTQuB (ORCPT ); Wed, 20 Jul 2022 12:50:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbiGTQuA (ORCPT ); Wed, 20 Jul 2022 12:50:00 -0400 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D63966AE1; Wed, 20 Jul 2022 09:49:59 -0700 (PDT) Received: from in02.mta.xmission.com ([166.70.13.52]:48622) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oECta-00C3oD-4N; Wed, 20 Jul 2022 10:49:58 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:40080 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oECtZ-002yu4-2v; Wed, 20 Jul 2022 10:49:57 -0600 From: "Eric W. Biederman" To: Jens Axboe Cc: Olivier Langlois , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Alexander Viro , Oleg Nesterov , Linus Torvalds References: <192c9697e379bf084636a8213108be6c3b948d0b.camel@trillion01.com> <9692dbb420eef43a9775f425cb8f6f33c9ba2db9.camel@trillion01.com> <87h7i694ij.fsf_-_@disp2133> <1b519092-2ebf-3800-306d-c354c24a9ad1@gmail.com> <13250a8d-1a59-4b7b-92e4-1231d73cbdda@gmail.com> <878rw9u6fb.fsf@email.froward.int.ebiederm.org> <303f7772-eb31-5beb-2bd0-4278566591b0@gmail.com> <87ilsg13yz.fsf@email.froward.int.ebiederm.org> <8218f1a245d054c940e25142fd00a5f17238d078.camel@trillion01.com> Date: Wed, 20 Jul 2022 11:49:31 -0500 In-Reply-To: (Jens Axboe's message of "Tue, 31 May 2022 21:15:57 -0600") Message-ID: <87y1wnrap0.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oECtZ-002yu4-2v;;;mid=<87y1wnrap0.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1+dx3F0RDR9KXL38YfycHH+G0LWPESKF84= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: [PATCH 0/2] coredump: Allow io_uring using apps to dump to pipes. X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Folks who have been suffering from io_uring coredumping issues please give this a spin. I have lightly tested this version and more heavily tested an earlier version which had more dependencies. Unless I have missed something in cleaning up the code this should be a comprehensive fix to the coredumping issues when using io_uring. But folks please test and verify this. It has taken me long enough to get back to this point I don't properly remember how the reproducer I have was supposed to fail. All I can say with certainty is set of changes has what looks like a positive effect. Eric W. Biederman (2): signal: Move stopping for the coredump from do_exit into get_signal coredump: Allow coredumps to pipes to work with io_uring fs/coredump.c | 30 ++++++++++++++++++++++++++++-- include/linux/coredump.h | 2 ++ kernel/exit.c | 29 +++++------------------------ kernel/signal.c | 5 +++++ mm/oom_kill.c | 2 +- 5 files changed, 41 insertions(+), 27 deletions(-) Eric