From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD95A8F6D for ; Sat, 1 Mar 2025 02:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740796400; cv=none; b=RNp7C9fWmAJQdn0oc8UBUZ9pBTz962OIoUF+YXQo6XjqOV95Ks5jbIJuylXqrXprdgfS4eceV5YTI0VTcUB51yVx1BfpIwnw6kmFj0tmJ5KvoUkpO73S2xid/Xg2xEK5INf9m3d+3OTnTqxNTEx1lMNnZJhtYQ5HwlvxE+lnomQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740796400; c=relaxed/simple; bh=7Wk4vA28rba6Vu9K4bmzBzhcMFB2S3VOwLvqpMjhBXc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VpksFp716n0cry0t1mDXEA++O8Hz/QLxnirVkP/HuARWdkDws2jc2MeWkqE0kOJk84Jl8SqzoyJF25zChp0ce3pf1STAfCOLPtoPDiqzLqGH0s68Tsxhff8nm0FUjLRFzWANDR4zHj2QuVMc562iBiOs+fdmPSFw3j0Awrbf7xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=JenOwQ3h; arc=none smtp.client-ip=209.85.219.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="JenOwQ3h" Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-e60a35eb84fso1859831276.3 for ; Fri, 28 Feb 2025 18:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1740796397; x=1741401197; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s2Y7PV9zs0gYf8Tt1Gn9HqJp4Nessds6ztaeQH7ivPk=; b=JenOwQ3hcDOZ9HnSVjyMLD/UAKGBbDEDK0q+9AeUCNjvKfhWNwQzC4MDO+LKntbJOD gBo2XpiWN8CCLDdqdocsuSsV3bV7SU0vuWSDQPu4iuzRwG2dW2VzoV6A5U4o6ow9nD/6 E4fL8Ato5FHs9PY/FvhRhHVqTCwbgP1txiVB45RcYJsQBIdxoiupv5ncihLfwoRqEmLv uBOhSmaubHILtjhajbCYu2vi0XnjWdtjeevsWs7mUT9zuT38/qbo7Y/J4kaxWZoZYIN+ ZtZ7ma9ggma4L7oMfgDpk5ssyBLssQv4MzfJqQRB/IQ4GI7WKcdyavl0vcDXxNUfr+q5 MELw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740796397; x=1741401197; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2Y7PV9zs0gYf8Tt1Gn9HqJp4Nessds6ztaeQH7ivPk=; b=Nidqn6GeLgg4W27OAF7UMOlYU8v03r2QfdH4Q+JIdDuQ07pit1rcodOvpzkBcSYit+ zcS2Y5ZA/77Q75dpLV0NdQ0SC9M1asqpkzPsNYtw/HPnIV1qFHz2u8sOXBue+qsBLga+ n8kCIzMhJ2tcFgjV9fjGJO8msdDRIY4kAp23GVMgSaPOi++mD6T4YC4dlbHNlEus/duF /5387V2FVILnsMgs51GoxwVbT1ITAn6DBggPFjhGnGUj3c/baaJl8sNOefxdOLIfHpkl kmP+vcdEUdq4SS55KJ0IOkHl2LvSWbXtywgIAEGrMvJdZLqWtQNjA8ERVph3gXwHYL5s DSPA== X-Gm-Message-State: AOJu0Ywv4sXJwRsJoVuu+7DtSQmr22pp5aSonWMqBnC6DyD6HrK0/AQR j9Srn9DMMlTCA7jfTS6nKUd4ZpDCzNjyMhiBIR/Rk6Cf0eMiL0z9MP2D6kb+DNs= X-Gm-Gg: ASbGncv2LNasaX7JONcQQc74xW3hyfWK+tx+N9ycqFWUK989XgLjJ8Mh/9UHpHFiBaJ S2bgYWeXNejEjdzOVHwptsa5wIl+BlGQTnuueTVIr3+6u/tF41EmhmBBeNLS1Tti90z/1UzzUmi AyQCNt6uONr5rJocAbyuPecTDKJi7qJsJ/sOgfl37blg2Yy30OLIgZqgewfby+S+16Wj2KMmQd6 14LnOnTvteqrIuWItaeKSQJ0Io2tEeWf4Y8jFo9GK/u452Owg7nBVicGLoZ6aJQnyqz5cGXsiFj rtEeBdVv7IM5fJrRLHdA3IYAI+eWgnPxoYIHPJk4siIX X-Google-Smtp-Source: AGHT+IEqTFM9YEjBMYUxDbhMLqG/qClqzb+9k7zk9QMQQVoQYG6ZWANlTYw1+3HQFaRAn0UUpMn3CQ== X-Received: by 2002:a05:6902:18d6:b0:e60:ac55:a68e with SMTP id 3f1490d57ef6-e60b2e940c4mr6040098276.3.1740796397510; Fri, 28 Feb 2025 18:33:17 -0800 (PST) Received: from [192.168.21.25] ([207.222.175.10]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e60a3aa530dsm1424867276.39.2025.02.28.18.33.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2025 18:33:16 -0800 (PST) Message-ID: <8855fc32-3cbf-450f-aca7-ed9d201a57ba@kernel.dk> Date: Fri, 28 Feb 2025 19:33:16 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file To: Pavel Begunkov , Caleb Sander Mateos Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250301001610.678223-1-csander@purestorage.com> <86d5f210-d70f-4854-8ecf-eb771f26685a@gmail.com> <76a9617b-b1c8-44b0-8355-948758f6e70a@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/28/25 7:31 PM, Pavel Begunkov wrote: > On 3/1/25 02:22, Jens Axboe wrote: >> On 2/28/25 7:04 PM, Caleb Sander Mateos wrote: >>> On Fri, Feb 28, 2025 at 5:45?PM Pavel Begunkov wrote: >>>> >>>> On 3/1/25 00:16, Caleb Sander Mateos wrote: >>>>> Declare io_find_buf_node() in io_uring/rsrc.h so it can be called from >>>>> other files. >>>>> >>>>> Signed-off-by: Caleb Sander Mateos >>>>> --- >>>>> io_uring/rsrc.c | 4 ++-- >>>>> io_uring/rsrc.h | 2 ++ >>>>> 2 files changed, 4 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c >>>>> index 45bfb37bca1e..4c4f57cd77f9 100644 >>>>> --- a/io_uring/rsrc.c >>>>> +++ b/io_uring/rsrc.c >>>>> @@ -1066,12 +1066,12 @@ static int io_import_fixed(int ddir, struct iov_iter *iter, >>>>> } >>>>> >>>>> return 0; >>>>> } >>>>> >>>>> -static inline struct io_rsrc_node *io_find_buf_node(struct io_kiocb *req, >>>>> - unsigned issue_flags) >>>> >>>> That's a hot path, an extra function call wouldn't be great, >>>> and it's an internal detail as well. Let's better see what we >>>> can do with the nop situation. >>> >>> I can add back inline. With that, there shouldn't be any difference to >>> the generated instructions for io_import_reg_buf(). >> >> Yeah, in general I don't like manual inlines, unless it's been proven >> that the compiler messes it up for some reason. If it's short enough >> it'll be inlined. > > It will _not_ be inlined in this case. Hmm ok - I wonder why that is. But if we want to force it to do that, then we can just re-add the inline for the local definition, that'll be fine with it still being non-static and available. -- Jens Axboe