From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: REQ_F_FORCE_ASYNC prep done too late
Date: Thu, 19 Mar 2020 08:48:22 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/19/20 4:41 AM, Pavel Begunkov wrote:
> On 3/19/2020 6:51 AM, Jens Axboe wrote:
>> A previous patch ensured that we always prepped requests that are
>> forced async, but it did so too late in the process. This can result
>> in 'sqe' already being NULL by the time we get to it:
>
> Isn't it fixed by f1d96a8fcbbbb ("io_uring: NULL-deref for
> IOSQE_{ASYNC,DRAIN}")? BTW, the same can happen with draining in
> io_req_defer() -> io_req_defer_prep().
>
> Can't look through your patches/RFC properly, but I will try do that
> this weekends.
Ah I think that it is, I was running the 5.7 branch and that one
doesn't have that patch. Disregard this one, I think we're fine.
--
Jens Axboe
prev parent reply other threads:[~2020-03-19 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 3:51 [PATCH] io_uring: REQ_F_FORCE_ASYNC prep done too late Jens Axboe
2020-03-19 10:41 ` Pavel Begunkov
2020-03-19 14:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox