public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: remove unsued assignment to pointer io
@ 2021-03-26 19:52 Colin King
  2021-03-26 23:07 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-03-26 19:52 UTC (permalink / raw)
  To: Jens Axboe, Pavel Begunkov, io-uring; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <[email protected]>

There is an assignment to io that is never read after the assignment,
the assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
 fs/io_uring.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 046216c1b7d5..17a8adec47f0 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4787,7 +4787,6 @@ static int io_connect(struct io_kiocb *req, unsigned int issue_flags)
 			ret = -ENOMEM;
 			goto out;
 		}
-		io = req->async_data;
 		memcpy(req->async_data, &__io, sizeof(__io));
 		return -EAGAIN;
 	}
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring: remove unsued assignment to pointer io
  2021-03-26 19:52 [PATCH] io_uring: remove unsued assignment to pointer io Colin King
@ 2021-03-26 23:07 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-03-26 23:07 UTC (permalink / raw)
  To: Colin King, Pavel Begunkov, io-uring; +Cc: kernel-janitors, linux-kernel

On 3/26/21 1:52 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
> 
> There is an assignment to io that is never read after the assignment,
> the assignment is redundant and can be removed.

Thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-26 23:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26 19:52 [PATCH] io_uring: remove unsued assignment to pointer io Colin King
2021-03-26 23:07 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox