Re: [PATCH] io_uring/dma-buf: don't fail fixed buffers without dma-buf support

[Pavel Begunkov <asml.silence@gmail.com>]

On 10/22/26 14:20, Anuj Gupta wrote:
> From: Anuj Gupta <anuj20.g@samsung.com>
> 
> io_attach_dmabuf_map() is called for every fixed read/write, but returns
> -EOPNOTSUPP when CONFIG_DMA_SHARED_BUFFER is disabled before checking
> whether the request uses a dma-buf at all. So READ_FIXED and WRITE_FIXED
> fail for ordinary registered buffers. Check REQ_F_DMABUF first.
> 
> Fixes: 62e4bf5b25d4 ("io_uring/rsrc: add dmabuf backed registered buffers")
> Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
> ---
>   io_uring/dma-buf.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/io_uring/dma-buf.h b/io_uring/dma-buf.h
> index a876a9e5e272..534c06b6879f 100644
> --- a/io_uring/dma-buf.h
> +++ b/io_uring/dma-buf.h
> @@ -34,10 +34,10 @@ static inline int io_attach_dmabuf_map(struct io_kiocb *req,
>   	struct dma_buf_io_map *map;
>   	struct io_buf_dma *bd;
>   
> -	if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
> -		return -EOPNOTSUPP;

Good catch. It was supposed to be

if (!IS_ENABLED(CONFIG_DMA_SHARED_BUFFER))
	return 0;

as there shouldn't be any dma-buf registered buffers
when it's disabled. Looks good in either case

-- 
Pavel Begunkov