From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C45C433E6 for ; Tue, 2 Feb 2021 17:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0CAF64F4D for ; Tue, 2 Feb 2021 17:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236892AbhBBR2s (ORCPT ); Tue, 2 Feb 2021 12:28:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237537AbhBBR0P (ORCPT ); Tue, 2 Feb 2021 12:26:15 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 985C7C061573 for ; Tue, 2 Feb 2021 09:25:36 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id y187so2997820wmd.3 for ; Tue, 02 Feb 2021 09:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0XR8V3GPBdMTnYoV1LA/5NdTsOikkvAl2toNSYUsPIM=; b=m2o8NnRc7S8jFiSUECCQZUISQsIFP8eSHUGc0rLiPJH7WVekTbRP6KP610pYjTUWaR Aabr+iwrh2dIOc9Z0N9hVyBYsw9EQsHHKQ+mDrC70XSXUTi4QcOHpFZxj3ALJ1q4Ihra LYo2NAoXbA3PDxaPjs2vxb2wHvAiZhrK+s1RE98sc++6DQSvxKgdM1aAdsNIjpJMz8Kz Lc7QuJF4u+vmIdWLnCuXupPlvm//4dX1+WbbQUPggm2jISY5ewgcy6H2eWTlh3q8Kc0T mc6OOCiL9Zgr9sSgn9FtTGck0qiuiQnfueWPa9mDPrKbD3RQklTdn8mw/nKJUeVSbU3H ZFJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0XR8V3GPBdMTnYoV1LA/5NdTsOikkvAl2toNSYUsPIM=; b=R1QIKNLgdV2UBl2RZbQV2QnofCd9BWBLbM+8OsM7zf8yfGZrCUuX2QZtCrTnnoC250 2LpcS5ENnZsU321RXSHQ98jSscgf4hIp9oM6xn1+lU7sufoi00CdjxbTtXR4SE/tIVM2 601QzLxLIr6ldgtDqTtFgg004BllVMu2+ybi4aqxHUknvmybkHL9V9ZRbph4Fo2HeRW/ Y8ltjlq8w+/iMvDy+voCDGlm2vf0sl7/mE0ffTdO9fB/39TH7fgBQ4QoBmJcpY2TGhKP PA4L9BJjs7mADg9tUC+XUjimhZz0A8uuGAyTSPLP3zi5S0PngwXM2GlYTVkUGrTmemOB A+rw== X-Gm-Message-State: AOAM533HUkwE927m0rmbXne9m5IotdWgNBOxYl/Q1LASjljzvdRk5GQu gZItU8uZqSnyZWfwj6frTJipojYjDvUbyw== X-Google-Smtp-Source: ABdhPJyuLP5BsBYnNWuES96hziUOKjRYFfb9hxFUghuUYBb98EWLl6a/7uVCqr42Q8urxr1mxOusyg== X-Received: by 2002:a05:600c:ce:: with SMTP id u14mr4672821wmm.10.1612286735057; Tue, 02 Feb 2021 09:25:35 -0800 (PST) Received: from [192.168.8.171] ([185.69.145.241]) by smtp.gmail.com with ESMTPSA id a132sm4144624wmf.42.2021.02.02.09.25.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 09:25:34 -0800 (PST) To: Victor Stewart Cc: io-uring References: <49743b61-3777-f152-e1d5-128a53803bcd@gmail.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: bug with fastpoll accept and sqpoll + IOSQE_FIXED_FILE Message-ID: <8a3ba4fc-6e60-a3e7-69f4-0394799e7fd7@gmail.com> Date: Tue, 2 Feb 2021 17:21:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 02/02/2021 16:18, Victor Stewart wrote: >>> Please don't forget about checking error codes. At least fixed >>> files don't work for you because of >>> >>> int fds[10]; >>> memset(fds, -1, 10); // 10 bytes, not 10 ints >>> >>> So io_uring_register_files() silently fails. > > well i'm glad this one was my own careless error. fresh eyes are > everything. you're right, bad habit of ignoring return values lol. > >> Also you forget to submit, all works with these 2 changes. >> >> When you don't do io_uring_submit(), apparently it gets live-locked >> in liburing's _io_uring_get_cqe(), that's a bug. > > in the comments above io_uring_wait_cqe_timeout it says it submits for > you, that's why i didn't submit here. but i guess great if that There is a change of behaviour, if IORING_FEAT_EXT_ARG is set it won't submit (IIRC, since 5.12) -- it's pretty important for some multi-threaded cases. So... where in particular does it say that? In case your liburing is up to date and we forgot to remove such a comment. > exposed the _io_uring_get_cqe bug. It's great for sure! > > thanks so much for taking a look at this Pavel > -- Pavel Begunkov