* [PATCH 1/1] io_uring: reuse io_should_terminate_tw() for cmds
@ 2025-01-15 15:40 Pavel Begunkov
2025-01-15 15:54 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2025-01-15 15:40 UTC (permalink / raw)
To: io-uring; +Cc: asml.silence
io_uring_cmd_work() rolled a hard coded version of
io_should_terminate_tw() to avoid conflicts, but now it's time to
converge them.
Signed-off-by: Pavel Begunkov <[email protected]>
---
io_uring/uring_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index d6ff803dbbe1..d235043db21e 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -105,7 +105,7 @@ static void io_uring_cmd_work(struct io_kiocb *req, struct io_tw_state *ts)
struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd);
unsigned int flags = IO_URING_F_COMPLETE_DEFER;
- if (current->flags & (PF_EXITING | PF_KTHREAD))
+ if (io_should_terminate_tw())
flags |= IO_URING_F_TASK_DEAD;
/* task_work executor checks the deffered list completion */
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] io_uring: reuse io_should_terminate_tw() for cmds
2025-01-15 15:40 [PATCH 1/1] io_uring: reuse io_should_terminate_tw() for cmds Pavel Begunkov
@ 2025-01-15 15:54 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2025-01-15 15:54 UTC (permalink / raw)
To: io-uring, Pavel Begunkov
On Wed, 15 Jan 2025 15:40:48 +0000, Pavel Begunkov wrote:
> io_uring_cmd_work() rolled a hard coded version of
> io_should_terminate_tw() to avoid conflicts, but now it's time to
> converge them.
>
>
Applied, thanks!
[1/1] io_uring: reuse io_should_terminate_tw() for cmds
(no commit info)
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-15 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-15 15:40 [PATCH 1/1] io_uring: reuse io_should_terminate_tw() for cmds Pavel Begunkov
2025-01-15 15:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox