From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A706EC3F2D2 for ; Fri, 6 Mar 2020 01:56:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73D3220848 for ; Fri, 6 Mar 2020 01:56:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="m0uGG95j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbgCFB4B (ORCPT ); Thu, 5 Mar 2020 20:56:01 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36687 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbgCFB4B (ORCPT ); Thu, 5 Mar 2020 20:56:01 -0500 Received: by mail-pg1-f195.google.com with SMTP id d9so324327pgu.3 for ; Thu, 05 Mar 2020 17:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kaXeesIPPJMvPx4kXVh7gCp+Z3uzVmJEDAEEcWfSDtk=; b=m0uGG95jnfdlAWS1zW5wrVlOCbHvBqS4pnLjhYDwoHSUSeZ0mdxsG7TrEgIOVlMyjJ XkqhXyi+g1rDj4yGoOYDzALFjGqSGhoAURaZPXV1WpQCz5ZEz8K7+C/j8ypaEekRQ5vX nG83Vbtwn11cHwxzs5q997ZKprD0v4/UHFRFyf84aZqL35AcJR4+nYOiO3zDUbZSHMEb ctLVvigiannkuT0QAk7SzuW6eUfJ5dkrx+E007kPyW4wT/qn6WevAXqYPHJ9Tu67CPjF HZhrubOk0/1pK7pirS8FoMwv/UibUoJ8ZYbez9HmrKF9Uj6vcglRbIPFmyM28N3iKiBN ekmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kaXeesIPPJMvPx4kXVh7gCp+Z3uzVmJEDAEEcWfSDtk=; b=pS30V8cf7V1ehpw4CogLCW8xArzpzDwzztdiFtMO40JaIiq5ejdt81Tq9IeDk8FLQZ pKQSI8HXUCVRN8spyc8MXxktTQuavo35Ww0W+n0Sa5Ac4InI3Mn+C7/RtKSlSX9xegdj SOF05vrVtVA1Rqhxrw/X3hfsbmPmLI64PL53d3peMzg6RruoqRKViVUcd10pngTdJ7z1 F97S9uBa9hKN2d8ju8MOFf4x9HDdN8X717kJxf834QcWYWCva4RnIfRhxjiVDZSsJM+6 UtbpBm4sIxmKD2BD8a83H04RashLflFJUTJClWKXdlGUERWIO6LqdnF8/XAIxynDSpa/ 3gmw== X-Gm-Message-State: ANhLgQ2lZ/WqP3bVmYVi4TlQq0dwkUd2qgRvZ4NtaH1rkQBDYakRC3Ul kzXf1w2K3k5siCZ3A4ejT2IAbg== X-Google-Smtp-Source: ADFU+vtqOTPBL+DI0/5IBgeGnVtrkQZjNncicf0Rr++POXk8uMRWYzPeLE+yHx0D7xZIm9ix3RJqHg== X-Received: by 2002:a63:d10c:: with SMTP id k12mr962268pgg.392.1583459758864; Thu, 05 Mar 2020 17:55:58 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id x16sm6615906pfq.40.2020.03.05.17.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 17:55:58 -0800 (PST) Subject: Re: [PATCH] io_uring: Fix error handling in __io_compat_recvmsg_copy_hdr() To: Dan Carpenter Cc: Alexander Viro , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200305200544.5wmrfo7hbfybp3w5@kili.mountain> From: Jens Axboe Message-ID: <8ae4f1e1-9158-4ec8-e6fc-87c836093b89@kernel.dk> Date: Thu, 5 Mar 2020 18:55:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200305200544.5wmrfo7hbfybp3w5@kili.mountain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/5/20 1:05 PM, Dan Carpenter wrote: > We need to check if __get_compat_msghdr() fails and return immediately > on error. Also if compat_import_iovec() fails then we should return a > negative error code, but the current behavior is to just return > success. Thanks, that certainly looks better... Applied. -- Jens Axboe