From: Jens Axboe <[email protected]>
To: Jeff Moyer <[email protected]>, Pavel Begunkov <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2] io_uring: remove req cancel in ->flush()
Date: Thu, 22 Oct 2020 12:01:07 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/22/20 11:52 AM, Jeff Moyer wrote:
> Pavel Begunkov <[email protected]> writes:
>
>> Every close(io_uring) causes cancellation of all inflight requests
>> carrying ->files. That's not nice but was neccessary up until recently.
>> Now task->files removal is handled in the core code, so that part of
>> flush can be removed.
>
> I don't understand the motivation for this patch. Why would an
> application close the io_uring fd with outstanding requests?
It normally wouldn't, of course. It's important to understand that this
triggers for _any_ close. So if the app did a dup+close, then it'd
still trigger.
The point is that previously we _had_ to cancel requests that had
->files assigned, due to using a weak reference. Now we no longer have
to, so the point is to just get rid of that previous oddity.
--
Jens Axboe
next prev parent reply other threads:[~2020-10-22 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 15:38 [PATCH v2] io_uring: remove req cancel in ->flush() Pavel Begunkov
2020-10-22 17:52 ` Jeff Moyer
2020-10-22 18:01 ` Jens Axboe [this message]
2020-10-22 18:49 ` Jeff Moyer
2020-10-22 20:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox