From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: pick up link work on submit reference drop
Date: Wed, 26 Feb 2020 07:04:23 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2/26/20 1:33 AM, Pavel Begunkov wrote:
> On 26/02/2020 01:18, Jens Axboe wrote:
>> So this found something funky, we really should only be picking up
>> the next request if we're dropping the final reference to the
>> request. And io_put_req_find_next() also says that in the comment,
>> but it always looks it up. That doesn't seem safe at all, I think
>> this is what it should be:
>
> It was weird indeed, it looks good. And now it's safe to do the same in
> io_wq_submit_work().
It is.
> Interestingly, this means that passing @nxt into the handlers is useless, as
> they won't ever return !=NULL, isn't it? I'll prepare the cleanup.
Indeed! That means we can get rid of that. We should do that for 5.7, though.
--
Jens Axboe
next prev parent reply other threads:[~2020-02-26 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:27 [PATCH] io_uring: pick up link work on submit reference drop Jens Axboe
2020-02-25 21:22 ` Pavel Begunkov
2020-02-25 21:25 ` Jens Axboe
2020-02-25 21:41 ` Jens Axboe
2020-02-25 22:18 ` Jens Axboe
2020-02-26 8:33 ` Pavel Begunkov
2020-02-26 9:46 ` Pavel Begunkov
2020-02-26 14:04 ` Jens Axboe [this message]
2020-02-25 21:45 ` Pavel Begunkov
2020-02-25 21:52 ` Pavel Begunkov
2020-02-25 22:24 ` Jens Axboe
2020-02-26 6:32 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox