From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A0CC32771 for ; Sat, 18 Jan 2020 20:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45D2724683 for ; Sat, 18 Jan 2020 20:46:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="Inb6NhQE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgARUqj (ORCPT ); Sat, 18 Jan 2020 15:46:39 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45008 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgARUqj (ORCPT ); Sat, 18 Jan 2020 15:46:39 -0500 Received: by mail-pl1-f193.google.com with SMTP id az3so11360109plb.11 for ; Sat, 18 Jan 2020 12:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=aBvwG5hs/viXjFOybOIYOqL0J9/NjAJR55aMcHkMqz4=; b=Inb6NhQE6dYl3CVHDsOi2zXEBpNBU5RUcTsbaziD/JicVz7jAIJPYErWhulW0IFZp3 cHAFAsTbSpWgpbFJmrSjM42Td8TOgCcYdYy14I3nGBDv1Qif2VoKS/CB+acWtavKJ7SA yL+4Zfo3ukT6yP30COGuuI27F4hb7jGd5IAngkeHzL2N+n5XFOsCnTwe0wpZGtlBFM2E Phwb0Q1CACMW+jKyz+hU1TlshN1a0cPwtEWQ8Jg1LpHoztXMOfGoktO0Eqj3YJu1U8Wv 7ObOXnYx0Q/fkRYmp7zdzu5D138+Tm0KDmQUxW55+WlEc2qeUHRMeeycc5FWTatrrW+g xKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aBvwG5hs/viXjFOybOIYOqL0J9/NjAJR55aMcHkMqz4=; b=nOuvoqzP0U0hyQFYrrMOcUFN52XKvg5vQZkCoM9Ro41ZTftsZgr1I6VE+Vw/WW78OR 9l87nPmhm0hE5s1HuiIHvdNQSu/Wr9NoDml1t/nvfpl3PnHtTg/L06G52/rmXpviC/bE KFjSzpngdJZcaahkCG3TdEgpkw3eUwwYJ5PtTCJVbyFY2/pq9lzDTMfOgjzTMpYzAvni IpfOKZLAh/zirmwLcPcNxY4wKWtWcm+APRLBgFqOPgjoXH7c76GxeRhevbQzADizc+tj kGVIIGrFYjaWZQjoyuAEzDLFYramIMskSWFhgHp4E4V1+UosceA4qAlqpyxU+A5z6BMt i+MA== X-Gm-Message-State: APjAAAX5XAz1OPaLs80U06E8DiIeMHN6rJRgaucEGZLSkUT9Q2fakFIh oHwLb2Uprb/ORxDAPZyzmb9PTxDfLJY= X-Google-Smtp-Source: APXvYqwWTGIwEbfvkeQFgWzlMG5o9J+qp/K4p7RgFLPHkAwxfZU7UIbBuw6opSlpBy0gmhhLpiTp6w== X-Received: by 2002:a17:90a:2351:: with SMTP id f75mr14131461pje.133.1579380399007; Sat, 18 Jan 2020 12:46:39 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id o7sm35806945pfg.138.2020.01.18.12.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2020 12:46:38 -0800 (PST) Subject: Re: [PATCH] io_uring: use labeled array init in io_op_defs To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <8eadfa1b-5dee-a6b4-e217-81fdd2484218@kernel.dk> Date: Sat, 18 Jan 2020 13:46:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/18/20 11:35 AM, Pavel Begunkov wrote: > Don't rely on implicit ordering of IORING_OP_ and explicitly place them > at a right place in io_op_defs. Now former comments are now a part of > the code and won't ever outdate. Looks good to me, thanks. Applied. -- Jens Axboe