From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A40C433F5 for ; Tue, 22 Feb 2022 18:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235007AbiBVSp3 (ORCPT ); Tue, 22 Feb 2022 13:45:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233215AbiBVSp3 (ORCPT ); Tue, 22 Feb 2022 13:45:29 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D88E9E576 for ; Tue, 22 Feb 2022 10:45:03 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id gf13-20020a17090ac7cd00b001bbfb9d760eso422314pjb.2 for ; Tue, 22 Feb 2022 10:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=HeUz8L5U6F1urqd7EsfxYqvd/5i63zeMc5upIKGPqZI=; b=v9XEdWlUXPIOPoMddgKZWBNHZbi/JdecC2wMMGFmQRNTchZoB7YKKlRrvuV+jUfWrK 4ksI0ZDSR1ERszX9wYfae+d5cVU7p5vUBS6tGjl1/p/t6bRVZxS9s4I731VIbJdPoJQ2 hvLRNSAtyGCb0BKH9f5Yu2jFz7KqNhrKG0Quwgq92P8cI6XMHojOCR6R8xV2v9injEqs 2QKvVMdEqcKkySmAzgYK7qIDKOV1n2naWn+chtetg1aIOSGwnTXapvhtzUu7b4JRRR0O +s7qJ1RDUr+5lf8KEe4ABRSzJbF/MbcV9uXn7bOufZSHCIiHjCu49VH7f8W/SIkz7Av3 YSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=HeUz8L5U6F1urqd7EsfxYqvd/5i63zeMc5upIKGPqZI=; b=x3uiucnj49DJevPNctvZEpcT8BaBjFUBvS33WED6v10u621l+L/WpC11XOKhO04rU3 RL+spXy6LSq0AszP6LJR95nuw9oVVkKHmcFkN+rmthUbgXkkbYKuAx1Ir9M6VPFS3rU8 54ddTX1Gl9vUxHcNmpPTnuaGRt2yHU0FsxBW+t2G4UmGbidkcYiqIpDhYeZS8LROiqBh 1noKQMIbu21olN2QJwcaAhqUatLz9lpuVH9AMi7leZ4f4zoCJ1xy1MoQEcXWA+9R+9qP lDvukMUNYJ6kyw+IpWVvUIan1jtJpatjY44jcP/uURQh6EsiS14415hMhF7V3RMtJVqE jv7Q== X-Gm-Message-State: AOAM532LhksND2ZVLxbedF9NNlBrPJKCDRcyRt2qyO44iJKuKRbVQz16 sC0k8tq5jcI9ne7eNLX4i6SwXQ== X-Google-Smtp-Source: ABdhPJw6jmU61mWl+8j7l4GNipTTegFKNrG5zN1E4vT2ygIjDr3ZXuSUw9ldm0HfKKqJcvKoiTPmiQ== X-Received: by 2002:a17:902:ba8a:b0:14e:e8e6:7215 with SMTP id k10-20020a170902ba8a00b0014ee8e67215mr24518244pls.135.1645555503098; Tue, 22 Feb 2022 10:45:03 -0800 (PST) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id t11sm23252703pgi.90.2022.02.22.10.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 10:45:02 -0800 (PST) Message-ID: <8ef27a29-1efc-9060-51cb-f77a3641f002@kernel.dk> Date: Tue, 22 Feb 2022 11:45:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v3 0/2] io-uring: Make statx api stable Content-Language: en-US From: Jens Axboe To: Stefan Roesch , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com Cc: viro@zeniv.linux.org.uk, Linus Torvalds References: <20220215180328.2320199-1-shr@fb.com> <539953d3-bc83-0b6d-24b3-214f6cdaeb65@kernel.dk> In-Reply-To: <539953d3-bc83-0b6d-24b3-214f6cdaeb65@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/18/22 9:15 AM, Jens Axboe wrote: > On 2/15/22 11:03 AM, Stefan Roesch wrote: >> One of the key architectual tenets of io-uring is to keep the >> parameters for io-uring stable. After the call has been submitted, >> its value can be changed. Unfortunaltely this is not the case for >> the current statx implementation. >> >> Patches: >> Patch 1: fs: replace const char* parameter in vfs_statx and do_statx with >> struct filename >> Create filename object outside of do_statx and vfs_statx, so io-uring >> can create the filename object during the prepare phase >> >> Patch 2: io-uring: Copy path name during prepare stage for statx >> Create and store filename object during prepare phase >> >> >> There is also a patch for the liburing libray to add a new test case. This >> patch makes sure that the api is stable. >> "liburing: add test for stable statx api" >> >> The patch has been tested with the liburing test suite and fstests. > > Al, are you happy with this version? I have staged this one for 5.18, it's in for-5.18/io_uring-statx. It will be sent separately from the general io_uring fixes/updates. -- Jens Axboe