public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH 1/1] io_uring: break iopolling on signal
Date: Wed, 9 Aug 2023 09:50:03 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 8/9/23 9:38 AM, Pavel Begunkov wrote:
> On 8/9/23 16:30, Jens Axboe wrote:
>> On 8/9/23 9:20 AM, Pavel Begunkov wrote:
>>> Don't keep spinning iopoll with a signal set. It'll eventually return
>>> back, e.g. by virtue of need_resched(), but it's not a nice user
>>> experience.
>>
>> I wonder if we shouldn't clean it up a bit while at it, the ret clearing
>> is kind of odd and only used in that one loop? Makes the break
>> conditions easier to read too, and makes it clear that we're returning
>> 0/-error rather than zero-or-positive/-error as well.
> 
> We can, but if we're backporting, which I suggest, let's better keep
> it simple and do all that as a follow up.

Sure, that's fine too. But can you turn it into a series of 2 then, with
the cleanup following?

-- 
Jens Axboe


  reply	other threads:[~2023-08-09 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 15:20 [PATCH 1/1] io_uring: break iopolling on signal Pavel Begunkov
2023-08-09 15:30 ` Jens Axboe
2023-08-09 15:38   ` Pavel Begunkov
2023-08-09 15:50     ` Jens Axboe [this message]
2023-08-09 15:58       ` Pavel Begunkov
2023-08-09 16:01         ` Jens Axboe
2023-08-09 16:01           ` Pavel Begunkov
2023-08-09 16:05             ` Jens Axboe
2023-08-09 16:18 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox