public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH v3 0/3] next work propagation
Date: Tue, 3 Mar 2020 21:52:01 +0300	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 03/03/2020 21:33, Pavel Begunkov wrote:
> The next propagation bits are done similarly as it was before, but
> - nxt stealing is now at top-level, but not hidden in handlers
> - ensure there is no with REQ_F_DONT_STEAL_NEXT

Forgot to update this part, and also add, that there is no
refcount_dec_fetch(), so I did

io_put_req_async_completion() {
        refcount_dec()
        refcount_read()
}

because checks in refcount*() are useful, and I intend to remove
refcount_dec() with the optimisation patches.

> 
> v2:
> - fix race cond in io_put_req_submission()
> - don't REQ_F_DONT_STEAL_NEXT for sync poll_add
> 
> v3: [patch 3/3] only
> - drop DONT_STEAL approach, and just check for refcount==1
> 
> Pavel Begunkov (3):
>   io_uring: make submission ref putting consistent
>   io_uring: remove @nxt from handlers
>   io_uring: get next work with submission ref drop
> 
>  fs/io_uring.c | 307 +++++++++++++++++++++++---------------------------
>  1 file changed, 140 insertions(+), 167 deletions(-)
> 

-- 
Pavel Begunkov

  parent reply	other threads:[~2020-03-03 18:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 18:33 [PATCH v3 0/3] next work propagation Pavel Begunkov
2020-03-03 18:33 ` [PATCH v3 1/3] io_uring: make submission ref putting consistent Pavel Begunkov
2020-03-03 18:33 ` [PATCH v3 2/3] io_uring: remove @nxt from handlers Pavel Begunkov
2020-03-03 18:33 ` [PATCH v3 3/3] io_uring: get next work with submission ref drop Pavel Begunkov
2020-03-03 18:52 ` Pavel Begunkov [this message]
2020-03-03 18:57   ` [PATCH v3 0/3] next work propagation Jens Axboe
2020-03-03 21:40 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox