From: Jens Axboe <[email protected]>
To: Colin King <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH][next][V2] io_uring: Fix incorrect sizeof operator for copy_from_user call
Date: Tue, 15 Jun 2021 15:37:34 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/15/21 7:00 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Static analysis is warning that the sizeof being used is should be
> of *data->tags[i] and not data->tags[i]. Although these are the same
> size on 64 bit systems it is not a portable assumption to assume
> this is true for all cases. Fix this by using a temporary pointer
> tag_slot to make the code a clearer.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-06-15 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:00 [PATCH][next][V2] io_uring: Fix incorrect sizeof operator for copy_from_user call Colin King
2021-06-15 13:35 ` Pavel Begunkov
2021-06-15 21:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox