From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC7AC433EF for ; Mon, 25 Jul 2022 10:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234080AbiGYKUN (ORCPT ); Mon, 25 Jul 2022 06:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231594AbiGYKUL (ORCPT ); Mon, 25 Jul 2022 06:20:11 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CFFE70 for ; Mon, 25 Jul 2022 03:20:10 -0700 (PDT) Received: from [192.168.88.254] (unknown [125.160.106.238]) by gnuweeb.org (Postfix) with ESMTPSA id ADC347E257; Mon, 25 Jul 2022 10:20:08 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1658744409; bh=T7MXuOouYZKP2Xr9Bmojh99klK11LObnd+vBt5z5AbM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QSwcYjoPB2GugSqdYjhi8CcyitenSHwdMc/4uQ/hVFyhx0vkeV63sLuIjzrDYb194 nF0CUQT49HP7Swrk3+BcdAbxCbs4PsmYpOnlFtMdJf+BCSRS6hICF20zo/Yq2yw0t+ JP1x1qzhGOIZt7nUE0ST5wHw33xu7M3CGFIlvvyJmhyxCgczcZO4emCzKtK4yixo8D THhxCCC0tYk6dwi80+/tyAiSLUJmEWIyU/r3Yu5uxO2u6wtAPBXktwIuy1xw1l435X HEIrMlD3yXgBRztksMhGd7iMeEkbUl8JzUaDepNjAn3vN9JfL9milvabSlifRHicNY xzsTn0hF/Gc+w== Message-ID: <912620ff-7a2e-80b8-eea4-6f231304e33d@gnuweeb.org> Date: Mon, 25 Jul 2022 17:20:06 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH liburing 2/4] liburing: add zc send and notif helpers Content-Language: en-US To: Pavel Begunkov Cc: Jens Axboe , io-uring Mailing List References: <7f705b208e5f7baa6ee94904e39d3d0da2e28150.1658743360.git.asml.silence@gmail.com> From: Ammar Faizi In-Reply-To: <7f705b208e5f7baa6ee94904e39d3d0da2e28150.1658743360.git.asml.silence@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Hi Pavel, On 7/25/22 5:03 PM, Pavel Begunkov wrote: > +static inline void io_uring_prep_notif_update(struct io_uring_sqe *sqe, > + __u64 new_tag, /* 0 to ignore */ > + unsigned offset, unsigned nr) > +{ > + io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, (void *)new_tag, nr, > + (__u64)offset); > + sqe->ioprio = IORING_RSRC_UPDATE_NOTIF; > +} > + This part breaks 32-bit architecture. include/liburing.h: In function ‘io_uring_prep_notif_update’: In file included from syscall.h:14, from setup.c:5: include/liburing.h: In function ‘io_uring_prep_notif_update’: include/liburing.h:716:59: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 716 | io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, (void *)new_tag, nr, | ^ include/liburing.h:716:59: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 716 | io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, (void *)new_tag, nr, | -- Ammar Faizi