From: Pavel Begunkov <[email protected]>
To: Dmitry Kadashev <[email protected]>
Cc: Jens Axboe <[email protected]>, Josef <[email protected]>,
Norman Maurer <[email protected]>,
io-uring <[email protected]>
Subject: Re: "Cannot allocate memory" on ring creation (not RLIMIT_MEMLOCK)
Date: Mon, 21 Dec 2020 15:36:23 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOKbgA7TyscndB7nn409NsFfoJriipHG80fgh=7SRESbiguNAg@mail.gmail.com>
On 21/12/2020 11:00, Dmitry Kadashev wrote:
> On Mon, Dec 21, 2020 at 5:35 PM Dmitry Kadashev <[email protected]> wrote:
>>
>> On Sun, Dec 20, 2020 at 7:59 AM Pavel Begunkov <[email protected]> wrote:
>>>
>>> On 20/12/2020 00:25, Jens Axboe wrote:
>>>> On 12/19/20 4:42 PM, Pavel Begunkov wrote:
>>>>> On 19/12/2020 23:13, Jens Axboe wrote:
>>>>>> On 12/19/20 2:54 PM, Jens Axboe wrote:
>>>>>>> On 12/19/20 1:51 PM, Josef wrote:
>>>>>>>>> And even more so, it's IOSQE_ASYNC on the IORING_OP_READ on an eventfd
>>>>>>>>> file descriptor. You probably don't want/mean to do that as it's
>>>>>>>>> pollable, I guess it's done because you just set it on all reads for the
>>>>>>>>> test?
>>>>>>>>
>>>>>>>> yes exactly, eventfd fd is blocking, so it actually makes no sense to
>>>>>>>> use IOSQE_ASYNC
>>>>>>>
>>>>>>> Right, and it's pollable too.
>>>>>>>
>>>>>>>> I just tested eventfd without the IOSQE_ASYNC flag, it seems to work
>>>>>>>> in my tests, thanks a lot :)
>>>>>>>>
>>>>>>>>> In any case, it should of course work. This is the leftover trace when
>>>>>>>>> we should be exiting, but an io-wq worker is still trying to get data
>>>>>>>>> from the eventfd:
>>>>>>>>
>>>>>>>> interesting, btw what kind of tool do you use for kernel debugging?
>>>>>>>
>>>>>>> Just poking at it and thinking about it, no hidden magic I'm afraid...
>>>>>>
>>>>>> Josef, can you try with this added? Looks bigger than it is, most of it
>>>>>> is just moving one function below another.
>>>>>
>>>>> Hmm, which kernel revision are you poking? Seems it doesn't match
>>>>> io_uring-5.10, and for 5.11 io_uring_cancel_files() is never called with
>>>>> NULL files.
>>>>>
>>>>> if (!files)
>>>>> __io_uring_cancel_task_requests(ctx, task);
>>>>> else
>>>>> io_uring_cancel_files(ctx, task, files);
>>>>
>>>> Yeah, I think I messed up. If files == NULL, then the task is going away.
>>>> So we should cancel all requests that match 'task', not just ones that
>>>> match task && files.
>>>>
>>>> Not sure I have much more time to look into this before next week, but
>>>> something like that.
>>>>
>>>> The problem case is the async worker being queued, long before the task
>>>> is killed and the contexts go away. But from exit_files(), we're only
>>>> concerned with canceling if we have inflight. Doesn't look right to me.
>>>
>>> In theory all that should be killed in io_ring_ctx_wait_and_kill(),
>>> of course that's if the ring itself is closed.
>>>
>>> Guys, do you share rings between processes? Explicitly like sending
>>> io_uring fd over a socket, or implicitly e.g. sharing fd tables
>>> (threads), or cloning with copying fd tables (and so taking a ref
>>> to a ring).
>>
>> We do not share rings between processes. Our rings are accessible from different
>> threads (under locks), but nothing fancy.
>>
>>> In other words, if you kill all your io_uring applications, does it
>>> go back to normal?
>>
>> I'm pretty sure it does not, the only fix is to reboot the box. But I'll find an
>> affected box and double check just in case.
>
> So, I've just tried stopping everything that uses io-uring. No io_wq* processes
> remained:
>
> $ ps ax | grep wq
> 9 ? I< 0:00 [mm_percpu_wq]
> 243 ? I< 0:00 [tpm_dev_wq]
> 246 ? I< 0:00 [devfreq_wq]
> 27922 pts/4 S+ 0:00 grep --colour=auto wq
> $
>
> But not a single ring (with size 1024) can be created afterwards anyway.
>
> Apparently the problem netty hit and this one are different?
Yep, looks like it
--
Pavel Begunkov
next prev parent reply other threads:[~2020-12-21 18:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 8:19 "Cannot allocate memory" on ring creation (not RLIMIT_MEMLOCK) Dmitry Kadashev
2020-12-17 8:26 ` Norman Maurer
2020-12-17 8:36 ` Dmitry Kadashev
2020-12-17 8:40 ` Dmitry Kadashev
2020-12-17 10:38 ` Josef
2020-12-17 11:10 ` Dmitry Kadashev
2020-12-17 13:43 ` Victor Stewart
2020-12-18 9:20 ` Dmitry Kadashev
2020-12-18 17:22 ` Jens Axboe
2020-12-18 15:26 ` Jens Axboe
2020-12-18 17:21 ` Josef
2020-12-18 17:23 ` Jens Axboe
2020-12-19 2:49 ` Josef
2020-12-19 16:13 ` Jens Axboe
2020-12-19 16:29 ` Jens Axboe
2020-12-19 17:11 ` Jens Axboe
2020-12-19 17:34 ` Norman Maurer
2020-12-19 17:38 ` Jens Axboe
2020-12-19 20:51 ` Josef
2020-12-19 21:54 ` Jens Axboe
2020-12-19 23:13 ` Jens Axboe
2020-12-19 23:42 ` Josef
2020-12-19 23:42 ` Pavel Begunkov
2020-12-20 0:25 ` Jens Axboe
2020-12-20 0:55 ` Pavel Begunkov
2020-12-21 10:35 ` Dmitry Kadashev
2020-12-21 10:49 ` Dmitry Kadashev
2020-12-21 11:00 ` Dmitry Kadashev
2020-12-21 15:36 ` Pavel Begunkov [this message]
2020-12-22 3:35 ` Pavel Begunkov
2020-12-22 4:07 ` Pavel Begunkov
2020-12-22 11:04 ` Dmitry Kadashev
2020-12-22 11:06 ` Dmitry Kadashev
2020-12-22 13:13 ` Dmitry Kadashev
2020-12-22 16:33 ` Pavel Begunkov
2020-12-23 8:39 ` Dmitry Kadashev
2020-12-23 9:38 ` Dmitry Kadashev
2020-12-23 11:48 ` Dmitry Kadashev
2020-12-23 12:27 ` Pavel Begunkov
2020-12-20 1:57 ` Pavel Begunkov
2020-12-20 7:13 ` Josef
2020-12-20 13:00 ` Pavel Begunkov
2020-12-20 14:19 ` Pavel Begunkov
2020-12-20 15:56 ` Josef
2020-12-20 15:58 ` Pavel Begunkov
2020-12-20 16:14 ` Jens Axboe
2020-12-20 16:59 ` Josef
2020-12-20 18:23 ` Josef
2020-12-20 18:41 ` Pavel Begunkov
2020-12-21 8:22 ` Josef
2020-12-21 15:30 ` Pavel Begunkov
2020-12-21 10:31 ` Dmitry Kadashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox