public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Changman Lee <[email protected]>, [email protected]
Subject: Re: io uring support for character device
Date: Tue, 24 May 2022 21:00:26 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN863PsXgkvi-NLhyLy-M+iQgaWeXtjM_MBoRc0H0fq2jTfU1w@mail.gmail.com>

On 5/24/22 6:56 PM, Changman Lee wrote:
> Hi List,
> 
> I'm CM Lee. I'm developing a custom character device managing pcie dma.
> I've tried to use io uring for the char device which supports readv
> and writev with synchronous and blocking manner and seek.
> When I use a io uring with IORING_SETUP_IOPOLL and IORING_SETUP_SQPOLL
> for reducing syscall overhead, a readv of the char device driver seems
> to be not called. So I added a_ops->direct_IO when the device is
> opened with O_DIRECT. But the result was the same.
> This is my question.
> Q1: Does io uring support a character device ?
> Q2: Is it better to reimplement a device driver as block device type ?

io_uring doesn't care what file type it is, I suspect your problem lies
elsewhere. Do you have a ->read() defined as well? If you do, the vfs
will pick that over ->read_iter().

If regular read/write works with O_DIRECT and reading from the device in
general, then io_uring will too.

-- 
Jens Axboe


  reply	other threads:[~2022-05-25  3:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  0:56 io uring support for character device Changman Lee
2022-05-25  3:00 ` Jens Axboe [this message]
2022-05-26  1:49   ` Changman Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox