public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Glauber Costa <[email protected]>
Cc: Avi Kivity <[email protected]>, [email protected]
Subject: Re: crash on accept
Date: Wed, 19 Feb 2020 19:53:05 -0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAD-J=zYcT6VSGhu81e=UJ3SrjfuPJLF9qB5T176OhZjfEpS26g@mail.gmail.com>

On 2/19/20 7:52 PM, Glauber Costa wrote:
> I don't see a crash now, thanks.

Updated again, should be more solid now. Just in case you run into
issues.

> I can now go back to trying to figure out why the test is just hanging
> forever, as I was doing earlier =)
> (99.9% I broke something with the last rework).
> 
> Out of curiosity, as it may help me with the above: I notice you
> didn't add a patch on top, but rather rebased the tree.

Yeah, the poll based async bits are very much a work in progress,
and I'll just fold fixes for now.

> What was the problem leading to the crash ?

It had to do with repeated retry. Eg we want to read from something,
we try and get -EAGAIN. Arm the poll handler, poll results says we're
good to go. Retry, get -EAGAIN again. Now we give up, but the state
wasn't restored properly.

-- 
Jens Axboe


      reply	other threads:[~2020-02-20  3:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAD-J=zZnmnjgC9Epd5muON2dx6reCzYMzJBD=jFekxB9mgp6GA@mail.gmail.com>
2020-02-19 20:09 ` crash on accept Jens Axboe
2020-02-19 20:11   ` Glauber Costa
2020-02-19 20:12     ` Jens Axboe
2020-02-19 20:25       ` Glauber Costa
2020-02-19 20:29         ` Avi Kivity
2020-02-19 23:09           ` Jens Axboe
2020-02-20  1:37             ` Jens Axboe
2020-02-20  2:52               ` Glauber Costa
2020-02-20  3:53                 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox