public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Minchan Kim <[email protected]>
Cc: Jann Horn <[email protected]>, io-uring <[email protected]>,
	Andrew Morton <[email protected]>,
	LKML <[email protected]>,
	linux-mm <[email protected]>,
	Linux API <[email protected]>,
	Oleksandr Natalenko <[email protected]>,
	Suren Baghdasaryan <[email protected]>,
	Tim Murray <[email protected]>,
	Daniel Colascione <[email protected]>,
	Sandeep Patil <[email protected]>,
	Sonny Rao <[email protected]>,
	Brian Geffon <[email protected]>, Michal Hocko <[email protected]>,
	Johannes Weiner <[email protected]>,
	Shakeel Butt <[email protected]>,
	John Dias <[email protected]>,
	Joel Fernandes <[email protected]>,
	[email protected],
	Alexander Duyck <[email protected]>
Subject: Re: [PATCH v5 1/7] mm: pass task and mm to do_madvise
Date: Fri, 14 Feb 2020 12:09:50 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2/14/20 11:45 AM, Minchan Kim wrote:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 63beda9bafc5..1c7e9cd6c8ce 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2736,7 +2736,7 @@ static int io_madvise(struct io_kiocb *req, struct io_kiocb **nxt,
>  	if (force_nonblock)
>  		return -EAGAIN;
>  
> -	ret = do_madvise(ma->addr, ma->len, ma->advice);
> +	ret = do_madvise(NULL, current->mm, ma->addr, ma->len, ma->advice);
>  	if (ret < 0)
>  		req_set_fail_links(req);
>  	io_cqring_add_event(req, ret);

I think we want to use req->work.mm here - it'll be the same as
current->mm at this point, but it makes it clear that we're using a
grabbed mm.

-- 
Jens Axboe


  reply	other threads:[~2020-02-14 19:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[email protected]>
     [not found] ` <[email protected]>
2020-02-14 17:25   ` [PATCH v5 1/7] mm: pass task and mm to do_madvise Jann Horn
2020-02-14 18:22     ` Jens Axboe
2020-02-14 18:45       ` Minchan Kim
2020-02-14 19:09         ` Jens Axboe [this message]
2020-02-14 19:31           ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox