From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A89C388F9 for ; Sun, 8 Nov 2020 23:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8596B206DB for ; Sun, 8 Nov 2020 23:18:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4dcL/BQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728006AbgKHXSQ (ORCPT ); Sun, 8 Nov 2020 18:18:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727949AbgKHXSP (ORCPT ); Sun, 8 Nov 2020 18:18:15 -0500 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B76E2C0613CF for ; Sun, 8 Nov 2020 15:18:15 -0800 (PST) Received: by mail-il1-x12b.google.com with SMTP id k1so6646763ilc.10 for ; Sun, 08 Nov 2020 15:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=69ZPEe7hNRDLTNb7t4JQwfRwAHTVryHFkvxizWRVyuQ=; b=M4dcL/BQPPV87++q1HgQRpB2ZYgU4xmMQJMwAI7Ry1anjHY5uikSO2jc5KXdfJO6Pl 8HLjCD9oIeWjzURdzxnXsZU3rl5dclzy4tVRrDPKbnD9nj4lHqfAQl0sd4+RRYQUvUz5 3JFWxpJXMert1wGM4tKS4qBYEMUFn9uvPeIia+G0bn2k7LkxrH3WzQ77HcRC0mml30E5 dvW0jsTL2F1qbmrnkp1aCyJdglWaSf/5mJvE8v86rgwwLw24jtjnBTA6P07jaguYjGBk uMdaqIw0GYF3q6nD8pK3b4OlcdZWD7b9iThE2EmaPDMjXGlJZv3xxIoFYeKKfiP6vPAS qQtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=69ZPEe7hNRDLTNb7t4JQwfRwAHTVryHFkvxizWRVyuQ=; b=DCTD1ZDEMGMzMEGXcuREs6Jn4L9MWv3MBe+HfoY9YkWOE0peijuDPt5UsHUZdKjk6F hYu+lSOz3Do9pilen2dosnfj2OBId/xrDJofu8FtFe1HSIJKvxR2mnzvc/5ChtPoMmgu f/G1LR0L/PpW8muLtIXSoEb5tSiYCUqlX1MBPHkv1ucPk1LgrB19BbG2I8iOZIhGWoYP AhFXjNjM+mOk5mD6qrNOUmV7jfXzjd9UD5zd0G8k96t793Gt5owRZ/eazGz/IzGkGlRT 4Stkn2e8TaJoizXk9F3Nt5t5oBM+Y8hpfF4rl2BHAjk5gh3EkS6vhySlqpBL3W1VCzxw wj2g== X-Gm-Message-State: AOAM533rLk439bi907jSL9OMoGRxRKxCExtBkSGaghihQIqYHFasLkcH w7viEDKRdNgU3r9fVh0r/PV8nahgX9I= X-Google-Smtp-Source: ABdhPJzGLprVqcX++y3p3wUeBR4lfq9XUFVdpmw9ZaeCF+8WnII0y2iZaG0Lc5Lyf7WIDrN5Rz8qeA== X-Received: by 2002:a92:9183:: with SMTP id e3mr8266308ill.111.1604877494863; Sun, 08 Nov 2020 15:18:14 -0800 (PST) Received: from Davids-MacBook-Pro.local ([2601:282:803:7700:59f:e9df:76ab:8876]) by smtp.googlemail.com with ESMTPSA id b9sm1670938ila.51.2020.11.08.15.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2020 15:18:14 -0800 (PST) Subject: Re: io-uring and tcp sockets To: Stefan Metzmacher , Jens Axboe , io-uring@vger.kernel.org References: <5324a8ca-bd5c-0599-d4d3-1e837338a7b5@gmail.com> From: David Ahern Message-ID: <9428d573-7155-0e4c-8c03-85bada9a0567@gmail.com> Date: Sun, 8 Nov 2020 16:18:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 11/4/20 10:08 AM, Stefan Metzmacher wrote: > sendmsg has msg_control, I think we'll need more interaction with the socket layer here > in order to wait in a single low level ->sendmsg_locked() call. > > I know IORING_OP_SENDMSG doesn't support msg_control currently, but I hope to get that fixed in future. That does not work. __io_queue_sqe calls io_issue_sqe with the force_nonblock flag set. io_send and io_sendmsg respond to that flag by setting MSG_DONTWAIT in the respective socket call. Hence, my question about the short send being by design.