From: Jens Axboe <[email protected]>
To: Xiaoguang Wang <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: [LIBURING PATCH] sq_ring_needs_enter: check whether there are sqes when SQPOLL is not enabled
Date: Mon, 13 Apr 2020 08:18:34 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/13/20 1:19 AM, Xiaoguang Wang wrote:
> Indeed I'm not sure this patch is necessary, robust applications
> should not call io_uring_submit when there are not sqes to submmit.
> But still try to add this check, I have seen some applications which
> call io_uring_submit(), but there are not sqes to submit.
Hmm, not sure it's worth complicating the submit path for that case.
A high performant application should not call io_uring_submit() if
it didn't queue anything new. Is this a common case you've seen?
--
Jens Axboe
next prev parent reply other threads:[~2020-04-13 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 7:19 [LIBURING PATCH] sq_ring_needs_enter: check whether there are sqes when SQPOLL is not enabled Xiaoguang Wang
2020-04-13 14:18 ` Jens Axboe [this message]
2020-04-13 15:46 ` Hrvoje Zeba
2020-04-13 15:59 ` Jens Axboe
2020-04-13 22:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox