Re: [PATCH] io_uring/parisc: Adjust pgoff in io_uring mmap() for parisc

[Jens Axboe <axboe@kernel.dk>]

On Aug 7, 2023, at 12:33 PM, Helge Deller <deller@gmx.de> wrote:
> 
> On 8/7/23 20:34, Jens Axboe wrote:
>> 
>>> On Mon, 07 Aug 2023 20:04:09 +0200, Helge Deller wrote:
>>> The changes from commit 32832a407a71 ("io_uring: Fix io_uring mmap() by
>>> using architecture-provided get_unmapped_area()") to the parisc
>>> implementation of get_unmapped_area() broke glibc's locale-gen
>>> executable when running on parisc.
>>> 
>>> This patch reverts those architecture-specific changes, and instead
>>> adjusts in io_uring_mmu_get_unmapped_area() the pgoff offset which is
>>> then given to parisc's get_unmapped_area() function.  This is much
>>> cleaner than the previous approach, and we still will get a coherent
>>> addresss.
>>> 
>>> [...]
>> 
>> Applied, thanks!
> 
> That was fast :-)
> Actually I had hoped for some more testing from Christoph and other
> parisc guys first.
> Anyway, since you have a parisc machine in your test ring, you will
> notice if something breaks,
> 
> What's important:
> Please add to the patch:
> Cc: stable@vger.kernel.org # 6.4

It’s not going upstream just yet, just easiser to apply for testing on my end. I will test it locally too.

— 
Jens Axboe