Re: [PATCH 2/5] io_uring: split alloc and add of overflow

[Jens Axboe <axboe@kernel.dk>]

On 5/17/25 5:30 PM, Caleb Sander Mateos wrote:
>> @@ -1425,20 +1441,19 @@ void __io_submit_flush_completions(struct io_ring_ctx *ctx)
>>                  */
>>                 if (!(req->flags & (REQ_F_CQE_SKIP | REQ_F_REISSUE)) &&
>>                     unlikely(!io_fill_cqe_req(ctx, req))) {
>> +                       gfp_t gfp = ctx->lockless_cq ? GFP_KERNEL : GFP_ATOMIC;
>> +                       struct io_overflow_cqe *ocqe;
>> +
>> +                       ocqe = io_alloc_ocqe(ctx, req->cqe.user_data, req->cqe.res,
>> +                                            req->cqe.flags, req->big_cqe.extra1,
>> +                                            req->big_cqe.extra2, gfp);
>>                         if (ctx->lockless_cq) {
>>                                 spin_lock(&ctx->completion_lock);
>> -                               io_cqring_event_overflow(req->ctx, req->cqe.user_data,
>> -                                                       req->cqe.res, req->cqe.flags,
>> -                                                       req->big_cqe.extra1,
>> -                                                       req->big_cqe.extra2);
>> +                               io_cqring_add_overflow(ctx, ocqe);
>>                                 spin_unlock(&ctx->completion_lock);
>>                         } else {
>> -                               io_cqring_event_overflow(req->ctx, req->cqe.user_data,
>> -                                                       req->cqe.res, req->cqe.flags,
>> -                                                       req->big_cqe.extra1,
>> -                                                       req->big_cqe.extra2);
>> +                               io_cqring_add_overflow(ctx, ocqe);
>>                         }
>> -
>>                         memset(&req->big_cqe, 0, sizeof(req->big_cqe));
> 
> Stray whitespace change. Either drop it or move it to the previous
> patch which added the blank line?

Thanks, I'll drop it here, patch 4/5 kills it anyway with removing the
memset.

-- 
Jens Axboe