public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH v2] io_uring: fix overflowed reqs cancellation
@ 2020-05-30 11:19 Pavel Begunkov
  2020-05-30 13:50 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2020-05-30 11:19 UTC (permalink / raw)
  To: Jens Axboe, io-uring, linux-kernel

Overflowed requests in io_uring_cancel_files() should be shed only of
inflight and overflowed refs. All other left references are owned by
someone else.

If refcount_sub_and_test() fails, it will go further and put put extra
ref, don't do that. Also, don't need to do io_wq_cancel_work()
for overflowed reqs, they will be let go shortly anyway.

Signed-off-by: Pavel Begunkov <[email protected]>
---

v2: don't schedule() if requests is already freed

 fs/io_uring.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index bc5117ee6ce3..b1c30284efbf 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -7447,10 +7447,11 @@ static void io_uring_cancel_files(struct io_ring_ctx *ctx,
 				finish_wait(&ctx->inflight_wait, &wait);
 				continue;
 			}
+		} else {
+			io_wq_cancel_work(ctx->io_wq, &cancel_req->work);
+			io_put_req(cancel_req);
 		}
 
-		io_wq_cancel_work(ctx->io_wq, &cancel_req->work);
-		io_put_req(cancel_req);
 		schedule();
 		finish_wait(&ctx->inflight_wait, &wait);
 	}
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] io_uring: fix overflowed reqs cancellation
  2020-05-30 11:19 [PATCH v2] io_uring: fix overflowed reqs cancellation Pavel Begunkov
@ 2020-05-30 13:50 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-05-30 13:50 UTC (permalink / raw)
  To: Pavel Begunkov, io-uring, linux-kernel

On 5/30/20 5:19 AM, Pavel Begunkov wrote:
> Overflowed requests in io_uring_cancel_files() should be shed only of
> inflight and overflowed refs. All other left references are owned by
> someone else.
> 
> If refcount_sub_and_test() fails, it will go further and put put extra
> ref, don't do that. Also, don't need to do io_wq_cancel_work()
> for overflowed reqs, they will be let go shortly anyway.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-30 13:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-30 11:19 [PATCH v2] io_uring: fix overflowed reqs cancellation Pavel Begunkov
2020-05-30 13:50 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox