From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF51C32771 for ; Wed, 28 Sep 2022 14:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233550AbiI1O2K (ORCPT ); Wed, 28 Sep 2022 10:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234351AbiI1O2I (ORCPT ); Wed, 28 Sep 2022 10:28:08 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61356AB42A for ; Wed, 28 Sep 2022 07:28:04 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id v10-20020a17090a634a00b00205e48cf845so2489059pjs.4 for ; Wed, 28 Sep 2022 07:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=RlRvct3277EYFToPkW4od6VyhmMFB2bnHNyqnEFyrBM=; b=CTdt4QqtPWlmjOer5e4jfzrIOLyZndPvQViX2DxuaaYRi8jdHNRDhr15r7TTLmXcif ebtsA7cI6Yht1jcDtTlaI7tNQWSyu3lyLXeJvrYgKh2N6YcU+2pmRUbVjWWDCE00cbeg CHLGEXblutHx4aNfjvq7TzZheZqNR2IMKSDnFFZItikZb4W9FkWqXYG/Yyghk5Y/aEwT Ety7xrr38GrtQZE8vq52oiX0kfyEPpqLuMs8SlObeRtqUOlmpbe7RPUep0w/NeKfsql0 6R5KsKOtX3ryXHOHNa0Qop+K8XGpOtUsbEPzMExvi7giv7WI3IsfIe2zhzJYnGWRov6U cyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=RlRvct3277EYFToPkW4od6VyhmMFB2bnHNyqnEFyrBM=; b=G+jXrfLHkPaEDtbKFKdxtzC9mysprhFhsIu00wUiA4yfiY102+P6SH4jlKnYcnSvwD aD8SC28q6aPxukRf2FheBrKRu0KbEDzRGtnuohN7AHb9s/8RqcGZIs0x16SmPUuphLPm e0Plfvh5T+UwTrPoCi8eOorIw8M1t8HKqUD7kJ2cxkux4ZrPjCWB62KXOIz7k3d0K24p 3XplrIKNcVMjAXyhecTwFUxmX2aLovZrwM5x15KglXBoklyQUiQqIysvjWyI1ms1UOmK /oqkgKVFfNZSIupdqk1bT3uHaCwo9lkkNwGmnY0zmzZLBkr6/vYcCAGgwCVXUuop7SIo T8fQ== X-Gm-Message-State: ACrzQf2cIb/DdUP1zYeR4+Ot3K6+eDrH1MrfUSNSgp/4TnkUIxH0veQ8 xsuuNVv4khh+eYV1ZKm5L6+rvA== X-Google-Smtp-Source: AMsMyM4REYpTDSAfEZcJo3ADi76E0K/8bIe2v79W+pe1cKZ3OjTnXEc2ij22YaVeD7Sl7qwFecHbkg== X-Received: by 2002:a17:902:dac7:b0:178:b5e0:3627 with SMTP id q7-20020a170902dac700b00178b5e03627mr72355plx.147.1664375283710; Wed, 28 Sep 2022 07:28:03 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id u8-20020a170903124800b00178b717a143sm3907725plh.126.2022.09.28.07.28.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 07:28:03 -0700 (PDT) Message-ID: <96154f6c-c02a-4364-c2a8-c714d79806d3@kernel.dk> Date: Wed, 28 Sep 2022 08:28:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH for-next v10 0/7] Fixed-buffer for uring-cmd/passthru Content-Language: en-US To: Kanchan Joshi , hch@lst.de, kbusch@kernel.org Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, gost.dev@samsung.com References: <20220927173610.7794-1-joshi.k@samsung.com> From: Jens Axboe In-Reply-To: <20220927173610.7794-1-joshi.k@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 9/27/22 11:36 AM, Kanchan Joshi wrote: > Hi > > uring-cmd lacks the ability to leverage the pre-registered buffers. > This series adds that support in uring-cmd, and plumbs nvme passthrough > to work with it. > Patch 3 and 4 contains a bunch of general nvme cleanups, which got added > along the iterations. > > Using registered-buffers showed IOPS hike from 1.65M to 2.04M. > Without fixedbufs > ***************** > # taskset -c 0 t/io_uring -b512 -d128 -c32 -s32 -p1 -F1 -B0 -O0 -n1 -u1 /dev/ng0n1 > submitter=0, tid=2178, file=/dev/ng0n1, node=-1 > polled=1, fixedbufs=0/0, register_files=1, buffered=1, QD=128 > Engine=io_uring, sq_ring=128, cq_ring=128 > IOPS=1.63M, BW=796MiB/s, IOS/call=32/31 > IOPS=1.64M, BW=800MiB/s, IOS/call=32/32 > IOPS=1.64M, BW=801MiB/s, IOS/call=32/32 > IOPS=1.65M, BW=803MiB/s, IOS/call=32/31 > ^CExiting on signal > Maximum IOPS=1.65M > > With fixedbufs > ************** > # taskset -c 0 t/io_uring -b512 -d128 -c32 -s32 -p1 -F1 -B1 -O0 -n1 -u1 /dev/ng0n1 > submitter=0, tid=2180, file=/dev/ng0n1, node=-1 > polled=1, fixedbufs=1/0, register_files=1, buffered=1, QD=128 > Engine=io_uring, sq_ring=128, cq_ring=128 > IOPS=2.03M, BW=991MiB/s, IOS/call=32/31 > IOPS=2.04M, BW=998MiB/s, IOS/call=32/32 > IOPS=2.04M, BW=997MiB/s, IOS/call=32/31 > ^CExiting on signal > Maximum IOPS=2.04M Christoph, are you happy with the changes at this point? -- Jens Axboe