From: Jens Axboe <axboe@kernel.dk>
To: Jann Horn <jannh@google.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
Dominik Maier <dmnk+artist@google.com>,
stable+noautosel@kernel.org
Subject: Re: [PATCH] io_uring/fdinfo: ignore IORING_CQE_F_32 in last CQ array slot
Date: Fri, 11 Sep 2026 09:55:46 -0600 [thread overview]
Message-ID: <962249a0-f5fd-447b-a52b-f5bef28f600f@kernel.dk> (raw)
In-Reply-To: <CAG48ez2J-MwLCS1NHV1+Yu12JpxiiL7_qfN6+37CAdeVZ8wJRQ@mail.gmail.com>
On 9/11/26 9:52 AM, Jann Horn wrote:
> On Fri, Sep 11, 2026 at 5:50?PM Jens Axboe <axboe@kernel.dk> wrote:
>> I did spot that as well, thanks for finishing it. Your fdinfo idea keeps
>> on giving, at least this one doesn't really matter :-)
>
> Ugh, yes. I hope it is at least somewhat useful for debugging, and
> doesn't _just_ cause lots of bugs?
Lots of bugs was earlier, and to be fair this one is caused by the more
recent addition of the mixed size CQEs. Everything is under the main
lock these days anyway, so it's more logic bugs like this one rather
than races, etc. I just like blaming you (a little bit), but in practice
it's not your fault.
--
Jens Axboe
next prev parent reply other threads:[~2026-09-11 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 15:34 [PATCH] io_uring/fdinfo: ignore IORING_CQE_F_32 in last CQ array slot Jann Horn
2026-09-11 15:37 ` Jann Horn
2026-09-11 15:44 ` Jann Horn
2026-09-11 15:50 ` Jens Axboe
2026-09-11 15:52 ` Jann Horn
2026-09-11 15:55 ` Jens Axboe [this message]
2026-09-11 16:33 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962249a0-f5fd-447b-a52b-f5bef28f600f@kernel.dk \
--to=axboe@kernel.dk \
--cc=dmnk+artist@google.com \
--cc=io-uring@vger.kernel.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable+noautosel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox